Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

t@h/osma layer: disused=yes not honoured #1079

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments
Closed

t@h/osma layer: disused=yes not honoured #1079

openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments

Comments

@openstreetmap-trac
Copy link

Reporter: a.t.chadwick[at]gmail.com
[Submitted to the original trac issue database at 11.20am, Monday, 28th July 2008]

Osmarender is rendering

amenity=pub
disused=yes

as if it were a normal pub at z=17. There aren't many disused pubs in the db admittedly, but I can see how this might affect other disused node types. Either greying such nodes out, rendering them with a cross through them, or not rendering them at all would be better.

Example: http://www.openstreetmap.org/?mlat=51.72631&mlon=-1.35204&zoom=17&layers=0B0FTF

Approved proposal: http://wiki.openstreetmap.org/index.php/Key:disused

@openstreetmap-trac
Copy link
Author

Author: Astrofreak85
[Added to the original trac issue at 2.35pm, Monday, 28th July 2008]

for railway=disused, too

@openstreetmap-trac
Copy link
Author

Author: a.t.chadwick[at]gmail.com
[Added to the original trac issue at 10.47am, Wednesday, 6th August 2008]

Affects canals too: http://www.openstreetmap.org/?mlat=51.66551&mlon=-1.29309&zoom=17&layers=0B0FTTT

I suggest a quick fix of simply not rendering anything tagged as disused=yes.

Upgrading to defect/minor and retitling: it affects more than just pubs.

@openstreetmap-trac
Copy link
Author

Author: a.t.chadwick[at]gmail.com
[Added to the original trac issue at 11.05am, Wednesday, 6th August 2008]

Also affects the website's mapnik layer: see #1085.

@openstreetmap-trac
Copy link
Author

Author: Mueck
[Added to the original trac issue at 10.43pm, Sunday, 25th January 2009]

I added some experimental rendering

please check, if something is forgotten or to much in this list ;-)

For highways and railways there exists the problem, that some application only can look at one key/value-pair, so highway=disused disused=primary is the better way for most applications, rendering supported for Osmarender experimentally at z17

@openstreetmap-trac
Copy link
Author

Author: bob[at]cakebox.net
[Added to the original trac issue at 6.04pm, Monday, 30th November 2009]

This type of tagging is extremely unfriendly to data consumers (don't assume that all data consumers that don't care about your pet tag supports it), and in osmarender it would require really big and ugly stylesheet changes to support it and it's related tags.

I'm not going to make the stylesheet almost impossible to figure out in order to support a bad tag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant