Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Changesets without a bounding box aren't shown on users changeset list. #1861

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 8 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Daeron
[Submitted to the original trac issue database at 5.12pm, Monday, 25th May 2009]

Changesets without a bounding box are not visible on the users edit history page.

eg. an edit made by me to just one relation: http://www.openstreetmap.org/browse/changeset/1321859 doesn't show on my list: http://www.openstreetmap.org/user/Daeron/edits

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 7.33am, Tuesday, 26th May 2009]

I believe this was a deliberate design decision, although your case is an interesting one as it shows that it is possible to have a non-empty changeset without a bounding box and I was told that the reasoning was that we didn't want to bother showing empty changesets.

@openstreetmap-trac
Copy link
Author

Author: zere
[Added to the original trac issue at 3.37pm, Tuesday, 26th May 2009]

(In [15237]) Better testing of bbox handling in relations. Maybe fixes #1861, but wasn't able to reproduce the exact case. Fixed bug handling bboxes where element is repeated in relation.

@openstreetmap-trac
Copy link
Author

Author: Matt
[Added to the original trac issue at 3.39pm, Tuesday, 26th May 2009]

resolution set to maybe fixed.

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 3.43pm, Tuesday, 26th May 2009]

Oh I see, I wasn't aware that we tried to update bboxes for relation changes. I thought we had just wimped out on that.

I'll deploy the change in a minute, but obviously this won't change the existing changeset so it is going to be hard to know if your change has actually fixed this or not...

@openstreetmap-trac
Copy link
Author

Author: Daeron
[Added to the original trac issue at 9.04pm, Friday, 4th September 2009]

Any news on this?

The problem occurs when only the ordering of a relation is changed. If members are added/removed, I think the bounding box is calculated for those objects and the problem doesn't show up.

I guess it would be pretty hard to decide what members were moved, eg. was it that one member was moved three places up, three members one place down, or both?

So what should the bounding box be for a just ordering change? All members could be too much if the relation is too big...

@openstreetmap-trac
Copy link
Author

Author: ToeBee
[Added to the original trac issue at 6.43am, Friday, 18th March 2011]

This bug appears to still exist.

Here is a changeset that only affected relations (deleting them):
http://www.openstreetmap.org/browse/changeset/7585986

It does not show up under the user's list of edits:
http://www.openstreetmap.org/user/hpawlow/edits

@openstreetmap-trac
Copy link
Author

Author: rickmastfan67
[Added to the original trac issue at 1.56am, Friday, 22nd July 2011]

It seems that this might be fixed now. I was just looking at the edit list of NE2, and an old changeset of his that didn't have a bounding box now shows up on his main edit list which I mentioned in #3837 which was closed as a duplicate of this ticket.

http://www.openstreetmap.org/user/NE2/edits Changeset: #8473084

I will not close it just yet, but I just wanted to put this out there.

@openstreetmap-trac
Copy link
Author

Author: Daeron
[Added to the original trac issue at 11.28am, Friday, 22nd July 2011]

Yes, seems to be fixed, probably when the list was changed to include the map. My original example is shown on my list (currently on page 320.. ;-) ), as is the one said by ToeBee.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant