Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

railway+bridge+service -> bridge will not render in Mapnik #2763

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments
Closed

railway+bridge+service -> bridge will not render in Mapnik #2763

openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments

Comments

@openstreetmap-trac
Copy link

Reporter: EvanE
[Submitted to the original trac issue database at 9.08pm, Monday, 1st March 2010]

When using railway=rail and bridge=yes (+layer=1) and service=siding (+lanes=1) then the bridge will not be rendered by Mapnik. It used to be rendered as a printout from nov. 25 2009 shows.

Example: [http://www.openstreetmap.org/?mlat=50.682229&mlon=7.162321&zoom=18&layers=B000FTF railway station Bonn-Bad-Godesberg (Germany), south-end]

Look for way [http://www.openstreetmap.org/browse/way/43043279/history 43.043.279].

If you continue the rails to the north-end you'll find bridge 43.357.466. There I have changed lanes=1 to tracks=1, in case that lanes=* is the problem.

Note: On the other parts of this station someone removed service=siding and lanes=1 in an attempt to have this area rendered as it should be rendered.

Edbert (EvanE)

@openstreetmap-trac
Copy link
Author

Author: Fips
[Added to the original trac issue at 6.51pm, Tuesday, 2nd March 2010]

If you have "service=spur", this bug happens, too.

See http://trac.openstreetmap.org/ticket/2767

@openstreetmap-trac
Copy link
Author

Author: ldp
[Added to the original trac issue at 10.28pm, Tuesday, 2nd March 2010]

(In [20253]) Add bridges to railway=rail + service=spur/siding/yard. Fixes #2763, #2767

@openstreetmap-trac
Copy link
Author

Author: EvanE
[Added to the original trac issue at 1.13am, Wednesday, 3rd March 2010]

The rule you added helps with railway=spur|siding|yard which is not the recommended
way to tag, though it is common through the TIGER-import.

Our problem is with railway=rail|light_rail|narrow_gauge|tram|subway|monorail|funicular|preserved|disused|abandoned plus service=siding|spur|yard plus bridge=yes|viaduct|swing|draw|...

Thus we need another filter with
[railway] = 'rail-light_rail-narrow_gauge-tram-subway-monorail-funicular-preserved-disused-abandoned' and [service] = 'spur-siding-yard' and [bridge] = 'yes-viaduct-swing-draw'

It might be necessary to slpit this filter further when it is wanted to draw some of railway, service or bridge in a different styles.

Edbert (EvanE)

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 8.56pm, Thursday, 4th March 2010]

You have misunderstood the patch. It will work for railway=rail + service=spur/siding/yard too.

The filter you wrote will never work. There are no railway= values in OSM. :-)

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 10.19pm, Wednesday, 10th March 2010]

As you can see, it now renders: http://www.openstreetmap.org/?way=43357466

@openstreetmap-trac
Copy link
Author

Author: EvanE
[Added to the original trac issue at 7.24am, Tuesday, 23rd March 2010]

Replying to [comment:4 Ldp]:

You have misunderstood the patch. It will work for railway=rail + service=spur/siding/yard too.

The filter you wrote will never work. There are no railway= values in OSM. :-)

Well, looking at your patch:
[railway] = 'spur-siding-yard' and [bridge] = 'yes'

It seems obvious that this filter matches railway=siding/yard/spur
but it is in no way obvious, that this filter matches the case of railway=rail + service=siding. So please excuse my misunderstandig.

However you have done it, rendering now works as wanted.

So thanks for the fast solution.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 6.46pm, Tuesday, 23rd March 2010]

Really, don't read anything special into 'spur-siding-yard'. The '-' characters are not any magic mapnik language construct, and this filter will quite literally match any literal 'spur-siding-yard' field in the SQL results.

However, scroll down to the , and see what preprocessing I do with SQL to understand why my patch does work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant