source: subversion/sites/rails_port/lib/consistency_validations.rb @ 17044

Last change on this file since 17044 was 15042, checked in by zere, 10 years ago

Added a consistency check that both ids are valid and match. Fixed diff upload code where this wasn't being set.

File size: 2.0 KB
Line 
1module ConsistencyValidations
2  # Generic checks that are run for the updates and deletes of
3  # node, ways and relations. This code is here to avoid duplication,
4  # and allow the extention of the checks without having to modify the
5  # code in 6 places for all the updates and deletes. Some of these tests are
6  # needed for creates, but are currently not run :-(
7  # This will throw an exception if there is an inconsistency
8  def check_consistency(old, new, user)
9    if new.id != old.id or new.id.nil? or old.id.nil?
10      raise OSM::APIPreconditionFailedError.new("New and old IDs don't match on #{new.class.to_s}. #{new.id} != #{old.id}.")
11    elsif new.version != old.version
12      raise OSM::APIVersionMismatchError.new(new.id, new.class.to_s, new.version, old.version)
13    elsif new.changeset.nil?
14      raise OSM::APIChangesetMissingError.new
15    elsif new.changeset.user_id != user.id
16      raise OSM::APIUserChangesetMismatchError.new
17    elsif not new.changeset.is_open?
18      raise OSM::APIChangesetAlreadyClosedError.new(new.changeset)
19    end
20  end
21 
22  # This is similar to above, just some validations don't apply
23  def check_create_consistency(new, user)
24    if new.changeset.nil?
25      raise OSM::APIChangesetMissingError.new
26    elsif new.changeset.user_id != user.id
27      raise OSM::APIUserChangesetMismatchError.new
28    elsif not new.changeset.is_open?
29      raise OSM::APIChangesetAlreadyClosedError.new(new.changeset)
30    end
31  end
32
33  ##
34  # subset of consistency checks which should be applied to almost
35  # all the changeset controller's writable methods.
36  def check_changeset_consistency(changeset, user)
37    # check user credentials - only the user who opened a changeset
38    # may alter it.
39    if changeset.nil?
40      raise OSM::APIChangesetMissingError.new
41    elsif user.id != changeset.user_id
42      raise OSM::APIUserChangesetMismatchError.new
43    elsif not changeset.is_open?
44      raise OSM::APIChangesetAlreadyClosedError.new(changeset)
45    end
46  end
47end
Note: See TracBrowser for help on using the repository browser.