Opened 11 years ago

Closed 11 years ago

#1035 closed defect (fixed)

Crash involving undo / redo over upload

Reported by: dantje Owned by: Chris Browet
Priority: critical Milestone:
Component: merkaartor Version:
Keywords: Cc:

Description

I suppose this issue can be split into multiple problems, but let me describe the whole sequence of what I did to break it. I made a screenshot at every step.

  1. Create two simple ways in OSM that look like Screenshot 1 and upload them. The restart, and download that very same data.
  1. Select the node where both ways meet and delete it
  1. Note how the selection in the way still shows the node, by now it can't be selected anymore. This is a bug by itself.
  1. Now make a new connection between the two ways.
  1. And join the two segments of the upper way
  1. Upload everything (There is no join or update command).
  1. We get a "Precondition failed" for the first node we deleted
  1. Try to upload the remaining "REMOVE" again
  1. Again the server responds with an error
  1. Now do undo to the beginning of the history. Now both ways show up, the old one and the new one.
  1. Redo to the end of the history again and go to "File/New?"

At this point my svn build segfaults (see backtrace.txt) when a base class MapLayer? destructor tries to delete its private data of an UploadedDataLayer?. In the backtrace I set a breakpoint on this destructor and stepped thru.

  1. The aftermath of the sequence on the server. The ways are not connected and the original connecting node is still there.

Attachments (13)

Screenshot1.png (105.5 KB) - added by dantje 11 years ago.
Screenshot2.png (118.0 KB) - added by dantje 11 years ago.
Screenshot3.png (105.9 KB) - added by dantje 11 years ago.
Screenshot4.png (107.1 KB) - added by dantje 11 years ago.
Screenshot5.png (107.2 KB) - added by dantje 11 years ago.
Screenshot6.png (124.2 KB) - added by dantje 11 years ago.
Screenshot7.png (124.6 KB) - added by dantje 11 years ago.
Screenshot8.png (111.5 KB) - added by dantje 11 years ago.
Screenshot9.png (122.0 KB) - added by dantje 11 years ago.
Screenshot10.png (71.0 KB) - added by dantje 11 years ago.
Screenshot11.png (72.3 KB) - added by dantje 11 years ago.
Screenshot12.png (72.6 KB) - added by dantje 11 years ago.
backtrace.txt (11.8 KB) - added by dantje 11 years ago.

Download all attachments as: .zip

Change History (16)

Changed 11 years ago by dantje

Attachment: Screenshot1.png added

Changed 11 years ago by dantje

Attachment: Screenshot2.png added

Changed 11 years ago by dantje

Attachment: Screenshot3.png added

Changed 11 years ago by dantje

Attachment: Screenshot4.png added

Changed 11 years ago by dantje

Attachment: Screenshot5.png added

Changed 11 years ago by dantje

Attachment: Screenshot6.png added

Changed 11 years ago by dantje

Attachment: Screenshot7.png added

Changed 11 years ago by dantje

Attachment: Screenshot8.png added

Changed 11 years ago by dantje

Attachment: Screenshot9.png added

Changed 11 years ago by dantje

Attachment: Screenshot10.png added

Changed 11 years ago by dantje

Attachment: Screenshot11.png added

Changed 11 years ago by dantje

Attachment: Screenshot12.png added

Changed 11 years ago by dantje

Attachment: backtrace.txt added

comment:1 Changed 11 years ago by Chris Browet

(In [8960]) FIX : Feature iterators became invalid after a modification on a download layer (refs #1035) FIX : "Cascaded" history were not read anymore from an MDC

comment:2 Changed 11 years ago by Chris Browet

Owner: changed from bvh-osm@… to Chris Browet
Status: newassigned

I think everything crumbled from 3) on. It's now solved so the remaining points should not happen anymore.

comment:3 Changed 11 years ago by Chris Browet

Resolution: fixed
Status: assignedclosed

Closing due to no further feedback. Reopen if needed.

Note: See TracTickets for help on using tickets.