Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Crash involving undo / redo over upload #1035

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

Crash involving undo / redo over upload #1035

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: dantje
[Submitted to the original trac issue database at 2.36pm, Saturday, 12th July 2008]

I suppose this issue can be split into multiple problems, but let me describe the whole sequence of what I did to break it. I made a screenshot at every step.

  1. Create two simple ways in OSM that look like Screenshot 1 and upload them. The restart, and download that very same data.

  2. Select the node where both ways meet and delete it

  3. Note how the selection in the way still shows the node, by now it can't be selected anymore. This is a bug by itself.

  4. Now make a new connection between the two ways.

  5. And join the two segments of the upper way

  6. Upload everything (There is no join or update command).

  7. We get a "Precondition failed" for the first node we deleted

  8. Try to upload the remaining "REMOVE" again

  9. Again the server responds with an error

  10. Now do undo to the beginning of the history. Now both ways show up, the old one and the new one.

  11. Redo to the end of the history again and go to "File/New"

At this point my svn build segfaults (see backtrace.txt) when
a base class MapLayer destructor tries to delete its private
data of an UploadedDataLayer. In the backtrace I set a
breakpoint on this destructor and stepped thru.

  1. The aftermath of the sequence on the server. The ways are not connected and the original connecting node is still there.
@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 11.19pm, Saturday, 12th July 2008]

(In [8960]) FIX : Feature iterators became invalid after a modification on a download layer (refs #1035)
FIX : "Cascaded" history were not read anymore from an MDC

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 11.23pm, Saturday, 12th July 2008]

I think everything crumbled from 3) on. It's now solved so the remaining points should not happen anymore.

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 9.17am, Saturday, 26th July 2008]

Closing due to no further feedback. Reopen if needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant