Opened 11 years ago

Closed 10 years ago

#1079 closed defect (wontfix)

t@h/osma layer: disused=yes not honoured

Reported by: achadwick Owned by: Jochen Topf
Priority: minor Milestone:
Component: osmarender Version:
Keywords: disused osmarender Cc:

Description

Osmarender is rendering

amenity=pub disused=yes

as if it were a normal pub at z=17. There aren't many disused pubs in the db admittedly, but I can see how this might affect other disused node types. Either greying such nodes out, rendering them with a cross through them, or not rendering them at all would be better.

Example: http://www.openstreetmap.org/?mlat=51.72631&mlon=-1.35204&zoom=17&layers=0B0FTF

Approved proposal: http://wiki.openstreetmap.org/index.php/Key:disused

Change History (5)

comment:1 Changed 11 years ago by Astrofreak85

for railway=disused, too

comment:2 Changed 11 years ago by achadwick

Priority: trivialminor
Summary: disused=yes not honoured (for pubs)disused=yes not honoured
Type: enhancementdefect

Affects canals too: http://www.openstreetmap.org/?mlat=51.66551&mlon=-1.29309&zoom=17&layers=0B0FTTT

I suggest a quick fix of simply not rendering anything tagged as disused=yes.

Upgrading to defect/minor and retitling: it affects more than just pubs.

comment:3 Changed 11 years ago by achadwick

Keywords: pub removed
Summary: disused=yes not honouredt@h/osma layer: disused=yes not honoured

Also affects the website's mapnik layer: see #1085.

comment:4 Changed 10 years ago by Heiko "Mueck" Jacobs

I added some experimental rendering

<rule e="node|way" k="amenity|man_made|leisure|shop|tourism|building" v="*">

<rule e="node|way" k="disused|abandoned" v="yes|true">

<symbol ref="disused" position="center"/>

</rule>

</rule>

please check, if something is forgotten or to much in this list ;-)

For highways and railways there exists the problem, that some application only can look at one key/value-pair, so highway=disused disused=primary is the better way for most applications, rendering supported for Osmarender experimentally at z17

comment:5 Changed 10 years ago by Knut Arne Bjørndal

Resolution: wontfix
Status: newclosed

This type of tagging is extremely unfriendly to data consumers (don't assume that all data consumers that don't care about your pet tag supports it), and in osmarender it would require really big and ugly stylesheet changes to support it and it's related tags.

I'm not going to make the stylesheet almost impossible to figure out in order to support a bad tag.

Note: See TracTickets for help on using tickets.