Opened 11 years ago

Closed 11 years ago

#1137 closed enhancement (fixed)

[PATCH] Move to the next field on enter in properties dock tags

Reported by: tcarter@… Owned by: Chris Browet
Priority: minor Milestone:
Component: merkaartor Version:
Keywords: Cc:

Description

The attached patch implements move to next field behavior when pressing enter/return when editing tags, this makes it easier to enter multiple tags without using the mouse.

Attachments (2)

merkaartor-tagview-nav.diff (1.6 KB) - added by tcarter@… 11 years ago.
merkaartor-tagview-nav2.diff (8.5 KB) - added by Travers Carter 11 years ago.
Further tagview keyboard navigation improvments

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by tcarter@…

Attachment: merkaartor-tagview-nav.diff added

comment:1 Changed 11 years ago by tcarter@…

Type: defectenhancement

comment:2 Changed 11 years ago by Chris Browet

Owner: changed from cbro@… to Chris Browet
Status: newassigned

Thanks for all your patches.

On this particular one, I'd like the escape key to just close / de-focus the current delegate tag edit, rather than the key to be passed to the main window, de-selecting the edited feature.

Do you think it is possible?

comment:3 Changed 11 years ago by tcarter@…

I would guess it should be possible, and that's I was trying for originally, but I haven't figured out how to override the global key binding for an individual widget yet.

It's something I'm planning to try to figure out though, I was also planning to bind F2 to start editing with the cursor at the end of the current tag name/value (eg like the standard rename shortcut), but it's globally bound to zoom all - do you think it would be appropriate to override that in the tag edit too?

comment:4 Changed 11 years ago by Chris Browet

(In [10442]) ADD : Support for GeoTagged? images. qmake GEOIMAGE=1 to activate. requires exiv2 (by Timo Schl?\195?\188?\195?\159ler) ADD : Move to the next field on enter in properties dock tags (by Travers Carter) (Refs #1137)

Changed 11 years ago by Travers Carter

Further tagview keyboard navigation improvments

comment:5 Changed 11 years ago by Travers Carter

I've updated the keyboard interactions

  • Escape now closes the edit delegate combobox without committing, but doesn't de-select
  • Cursor keys now navigate through the table cells
  • F2 starts an edit without overwriting the current cell's contents
  • Delete starts an edit clearing the current cell's contents
  • Tab/Backtab? now only cycles through tag names/values when an edit delegate is open, I think this is better because you can Tab/Backtab? to the other Docks and widgets more easily, but just ignore the .ui changes if you disagree)
  • Applied the width & nav fix to the MultiUI tagview too.

The attached patch (merkaartor-tagview-nav2.diff) is against the current SVN

comment:6 Changed 11 years ago by Chris Browet

Thanks!

comment:7 Changed 11 years ago by Chris Browet

Resolution: fixed
Status: assignedclosed

(In [10801]) ADD : Move to the next field on enter in properties dock tags - part 2 (by Travers Carter) (closes #1137) FIX : compile error on GCC

Note: See TracTickets for help on using tickets.