Opened 14 years ago

Closed 9 years ago

#116 closed defect (fixed)

Change "uid" to "id".

Reported by: Immanuel Scholz Owned by: mikel_maron@…
Priority: minor Milestone:
Component: datasources Version:
Keywords: Cc:

Description

"uid" is commonly used as "universal identifier" or "unique identifier". Both spellings means, that the id is unique among a great set of data, at least the whole dataset in mention.

This is not true for the osm id, which is not unique among different data types (nor it is among one type when history is taken into account).

It is confusing to name things in an unnatural way. Please change the name to the more restrictive "id" or something else.

Imi.

Change History (2)

comment:1 Changed 12 years ago by rjmunro@…

As far as I can see, in the rails port uid is only used to mean user id, except for 3 indexes on the MySQL tables.

In: source:sites/rails_port/db/migrate/001_create_osm_db.rb

  • add_index "gps_points", ["user_id"], :name => "points_uid_idx"
  • add_index "nodes", ["id"], :name => "nodes_uid_idx"
  • add_index "segments", ["id"], :name => "street_segment_uid_idx"

These indexes should be renamed. After that, I think the bug can be closed.

comment:2 Changed 9 years ago by Andy Allan

Resolution: fixed
Status: newclosed

As per the previous comment three years ago, this is effectively fixed.

Note: See TracTickets for help on using tickets.