Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

http://tah.openstreetmap.org/Request/create/ does not handle zoom correctly #1178

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 10 comments

Comments

@openstreetmap-trac
Copy link

Reporter: openstreetmap[at]dstoecker.de
[Submitted to the original trac issue database at 2.54pm, Wednesday, 17th September 2008]

When I do a

http://tah.openstreetmap.org/Request/create/?x=136&y=85&priority=1&src=test&z=8&random=1

the result is

Render 'tile,maplint,captionless' (12,136,85) at priority 2

Whereas the change in priority is ok, the change in zoomlevel is not. The coordinates of zoom level 8 do not match the ones of 12. So either the request is ignored totally or it is correctly
handled as level 8.

P.S. The above is the result of looking behind the scenes of www.informationfreeway.org, where these request are created.

@openstreetmap-trac
Copy link
Author

Author: openstreetmap[at]dstoecker.de
[Added to the original trac issue at 3.40pm, Wednesday, 17th September 2008]

I also found the reason. The parameter is "min_z" and not z. Thus Javascript of IFW must be fixed.

@openstreetmap-trac
Copy link
Author

Author: openstreetmap[at]dstoecker.de
[Added to the original trac issue at 3.43pm, Wednesday, 17th September 2008]

And another note: The rendering should is done on level 6 and 12 only, no longer 8. So also the text telling me to request on level 8 must be fixed. And also on level 8 no longer the selection box must be drawn.

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 11.06pm, Friday, 19th September 2008]

Information freeway is not operated or maintained by the OSM administrators - you need to contact the IFW owner (Etienne Cherdlu) to resolve any problems you have with it.

@openstreetmap-trac
Copy link
Author

Author: stoecker
[Added to the original trac issue at 7.10am, Thursday, 25th September 2008]

Beside the above the topic is still correct.

http://tah.openstreetmap.org/Request/create/ does not handle zoom correctly -->
When a request in level 6 is made, it is handled as a level 12 request.

I tried to have a look at the source code, but did not find the place, where the 6 is changed into a 12.

A little patch (don't know if correct, but should show be clear what's meant) during my search. This fixes the max_z value, but not the general issue.

Index: requests/models.py

--- requests/models.py (Revision 10480)
+++ requests/models.py (Arbeitskopie)
@@ -9,9 +9,9 @
x = models.PositiveSmallIntegerField()
y = models.PositiveSmallIntegerField()

  • render tiles from zoom levl min_z through max_z

  • render tiles from zoom leel min_z through max_z

    min_z = models.PositiveSmallIntegerField(default=12)
  • max_z = models.PositiveSmallIntegerField(default=17)
  • max_z = models.PositiveSmallIntegerField(default=min_z+5)

    list of layers we should render

    layers = models.ManyToManyField(Layer,null=True)

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 3.38pm, Thursday, 25th September 2008]

As I explained before, this is an IFW issue, not an OSM issue, so please stop reopening this ticket and go talk to somebody that can actually help you, which is not anybody who will be reading this.

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 3.39pm, Thursday, 25th September 2008]

Gah. I see it is actually an osmarender issue, not an IFW issue...

@openstreetmap-trac
Copy link
Author

Author: osm[at]petschge.de
[Added to the original trac issue at 9.28pm, Sunday, 28th December 2008]

I think this should go in the (new) tilesathome component...

@openstreetmap-trac
Copy link
Author

Author: spaetz
[Added to the original trac issue at 11.07am, Monday, 4th May 2009]

http://tah.openstreetmap.org/Request/create/?x=136&y=85&priority=1&src=test&z=8&random=1
the result is
Render 'tile,maplint,captionless' (12,136,85) at priority 2 

Yes and that is correct, there IS no zoom level 8 rendering. If the server accepted that what should it do with it? A tile set file is z6-11 or z12-17 and nothing inbetween, indeed if a client uploaded a z8-11 tileset file the server would (correctly) discard it as invalid. Therefore the patch to allow z=8 will not help anyway.

As for the z6 rendering. That is correct too, because t@h clients are AFAIK not capable of rendering low zoom requests by default, it currently needs much trickery to get that going. Also given the enormously bigger data/render efforts needed for lowzoom rendering, I don't think we should let people request those renderings from the user side. Make t@h client handle low zoom requests, and I'll change the server to automatically insert them to required areas and issue them to client.

@openstreetmap-trac
Copy link
Author

Author: spaetz
[Added to the original trac issue at 11.19am, Monday, 4th May 2009]

To make the server future proof (when clients understand low zoom render requests), I applied your patch to the server.

TypeError:
unsupported operand type(s) for +: 'PositiveSmallIntegerField' and 'int'
Exception Location: 	/var/www/tilesAtHome/tah/requests/models.py in Request, line 14

so your patch doesn't work.

@openstreetmap-trac
Copy link
Author

Author: iandees
[Added to the original trac issue at 8.56pm, Monday, 9th September 2013]

Cleaning aging tickets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant