Ticket #1178 (closed enhancement: wontfix)

Opened 6 years ago

Last modified 7 months ago

http://tah.openstreetmap.org/Request/create/ does not handle zoom correctly

Reported by: openstreetmap@… Owned by: spaetz
Priority: minor Milestone:
Component: tilesathome Version:
Keywords: Cc:

Description

When I do a

 http://tah.openstreetmap.org/Request/create/?x=136&y=85&priority=1&src=test&z=8&random=1

the result is

Render 'tile,maplint,captionless' (12,136,85) at priority 2

Whereas the change in priority is ok, the change in zoomlevel is not. The coordinates of zoom level 8 do not match the ones of 12. So either the request is ignored totally or it is correctly handled as level 8.

P.S. The above is the result of looking behind the scenes of www.informationfreeway.org, where these request are created.

Attachments

a.diff Download (645 bytes) - added by stoecker 6 years ago.
Proper diff :-)

Change History

comment:1 Changed 6 years ago by openstreetmap@…

I also found the reason. The parameter is "min_z" and not z. Thus Javascript of IFW must be fixed.

comment:2 Changed 6 years ago by openstreetmap@…

And another note: The rendering should is done on level 6 and 12 only, no longer 8. So also the text telling me to request on level 8 must be fixed. And also on level 8 no longer the selection box must be drawn.

comment:3 Changed 6 years ago by tom@…

  • Status changed from new to closed
  • Resolution set to invalid

Information freeway is not operated or maintained by the OSM administrators - you need to contact the IFW owner (Etienne Cherdlu) to resolve any problems you have with it.

comment:4 Changed 6 years ago by stoecker

  • Status changed from closed to reopened
  • Resolution invalid deleted

Beside the above the topic is still correct.

 http://tah.openstreetmap.org/Request/create/ does not handle zoom correctly --> When a request in level 6 is made, it is handled as a level 12 request.

I tried to have a look at the source code, but did not find the place, where the 6 is changed into a 12.

A little patch (don't know if correct, but should show be clear what's meant) during my search. This fixes the max_z value, but not the general issue.

Index: requests/models.py =================================================================== --- requests/models.py (Revision 10480) +++ requests/models.py (Arbeitskopie) @@ -9,9 +9,9 @@

x = models.PositiveSmallIntegerField?() y = models.PositiveSmallIntegerField?()

  • # render tiles from zoom levl min_z through max_z

+ # render tiles from zoom leel min_z through max_z

min_z = models.PositiveSmallIntegerField?(default=12)

+ max_z = models.PositiveSmallIntegerField?(default=min_z+5)

# list of layers we should render layers = models.ManyToManyField?(Layer,null=True)

comment:5 Changed 6 years ago by stoecker

  • Component changed from admin to slippy_map

Changed 6 years ago by stoecker

Proper diff :-)

comment:6 Changed 6 years ago by tom@…

  • Status changed from reopened to closed
  • Resolution set to invalid

As I explained before, this is an IFW issue, not an OSM issue, so please stop reopening this ticket and go talk to somebody that can actually help you, which is not anybody who will be reading this.

comment:7 Changed 6 years ago by tom@…

  • Status changed from closed to reopened
  • Resolution invalid deleted
  • Component changed from slippy_map to osmarender

Gah. I see it is actually an osmarender issue, not an IFW issue...

comment:8 Changed 5 years ago by osm@…

I think this should go in the (new) tilesathome component...

comment:9 Changed 5 years ago by osm@…

  • Component changed from osmarender to tilesathome

comment:10 Changed 5 years ago by tom@…

  • Owner changed from tom@… to osm@…
  • Status changed from reopened to new

comment:11 Changed 5 years ago by spaetz

  • Owner changed from osm@… to spaetz
  • Priority changed from major to minor
  • Status changed from new to assigned
  • Type changed from defect to enhancement

{{{When I do a  http://tah.openstreetmap.org/Request/create/?x=136&y=85&priority=1&src=test&z=8&random=1 the result is Render 'tile,maplint,captionless' (12,136,85) at priority 2 }}}

Yes and that is correct, there *IS* no zoom level 8 rendering. If the server accepted that what should it do with it? A tile set file is z6-11 or z12-17 and nothing inbetween, indeed if a client uploaded a z8-11 tileset file the server would (correctly) discard it as invalid. Therefore the patch to allow z=8 will not help anyway.

As for the z6 rendering. That is correct too, because t@h clients are AFAIK not capable of rendering low zoom requests by default, it currently needs much trickery to get that going. Also given the enormously bigger data/render efforts needed for lowzoom rendering, I don't think we should let people request those renderings from the user side. Make t@h client handle low zoom requests, and I'll change the server to automatically insert them to required areas and issue them to client.

comment:12 Changed 5 years ago by spaetz

To make the server future proof (when clients understand low zoom render requests), I applied your patch to the server.

TypeError:
unsupported operand type(s) for +: 'PositiveSmallIntegerField' and 'int'
Exception Location: 	/var/www/tilesAtHome/tah/requests/models.py in Request, line 14

so your patch doesn't work.

comment:13 Changed 7 months ago by iandees

  • Status changed from assigned to closed
  • Resolution set to wontfix

Cleaning aging tickets.

Note: See TracTickets for help on using tickets.