Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Icons not shown consistently on buildings #1226

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments
Closed

Icons not shown consistently on buildings #1226

openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments

Comments

@openstreetmap-trac
Copy link

Reporter: chriscf
[Submitted to the original trac issue database at 5.25pm, Wednesday, 1st October 2008]

Point features tagged shop=supermarket are rendered with a trolley icon. Area features with the same tag also bear the icon.

Point features tagged tourism=hotel are rendered with a bed icon. Area features with the same tag do not bear the icon.

Area features should consistently be either with or without the corresponding icon shown for point features.

@openstreetmap-trac
Copy link
Author

Author: jttt
[Added to the original trac issue at 7.47pm, Thursday, 2nd October 2008]

This is a bit more complicated. Osmarender used to have no support for area symbols and then area symbols were too slow so not used in rules files too often. But people wanted icons on their buildings so now you have plenty of areas with amenity=something and inside node with amenity=thesamesomething.

AFAIK mapnik is not rendering many area symbols neither so if you know make osmarender render all area symbols, you will end up with either building with two symbols in osmarender or building with not symbol at all in mapnik.

Personally I think this is a good change, but it should be coordinated with mapnik. Also we will get many double icons on map for some time. Look for example at amenity=parking which used to have only node symbol and now how both node and area symbol.

@openstreetmap-trac
Copy link
Author

Author: chriscf
[Added to the original trac issue at 8.43am, Friday, 3rd October 2008]

Where I have found things such as car parks marked as an area with a point inside, I have removed the point in order to only display the icon once. Co-ordinating the change with a similar change in mapnik would be a good idea, but I don't believe it to be essential - my understanding was that the two were very different beasts, and to be treated as such. In particular, the mapnik docs seem to give very little away about what format those directives should take.

@openstreetmap-trac
Copy link
Author

Author: jttt
[Added to the original trac issue at 5.04pm, Tuesday, 7th October 2008]

Please ask at tilesathome[at]openstreetmap.org. If nobody complains there I'll be happy to commit the patch.

@openstreetmap-trac
Copy link
Author

Author: dieterdreist
[Added to the original trac issue at 9.34pm, Saturday, 8th November 2008]

I also think that it is a useful patch - indeed very useful. There is just one problem with it as I also pointed out on the T@H-ML: there is no handling for the placement of the description/name of the feature. Assuming the above changes applied the text would overlap with the symbol. Please change this according to the parking-symbol for areas (see Osmarules Z17, parking area.)(it's very simple, just add the relevant tags in the already existing rule for textplacement, find it searching for parking).

For place of worship I made a compliant patch some time ago, but it was not yet uploaded.

@openstreetmap-trac
Copy link
Author

Author: studerap
[Added to the original trac issue at 3.11pm, Sunday, 9th November 2008]

(In [11839]) fix #1226, thanks to chriscf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant