Opened 11 years ago

Closed 11 years ago

#1242 closed defect (fixed)

color settings in site.css make site invisible with non-standard color scheme

Reported by: phaensch@… Owned by: Hugh Barnes
Priority: minor Milestone:
Component: website Version:
Keywords: css stylesheet colour usability accessibility Cc:

Description

This bug is rally nasty but should be very easy to fix, i wonder why nobody has noticed it yet.

The site.css file for your entire website (including the mainpage www.openstreetmap.org) includes the following paragraph:

body {

font-family: Arial,sans-serif; color: Black; margin: 0; padding: 0;

}

as you can see the textcolor for the whole page is set to black while there is no background color defined. This is critical for users having their desktop style configured to show a black background with, say white or red text on it.

While the users foreground color (which would be viewable on the users background color) is overridden the users background color is still displayed by the browser. Well, this makes the site appear with black text on black background, which is naturally unreadable.

The fault lies neither in the users settings as they would look nice if not overridden by the css nor does it lie in the webbrowsers rendering engine as it behaves exactly the way one would expect. The webdesigner simply assumed that every visitors would use the default (even worse, the MS Windows default) color scheme to display the Website.

Well, shouldn't be that hard to insert the line background: White; into the body-paragraph of your site.css ;-) Even better style with hex colors:

body {

font-family: Arial,sans-serif; color: #000000; background: #FFFFFF; margin: 0; padding: 0;

}

Critical thing about this bug is: it's so awkward for the guys at openstreetmap. Attached is a screenshot, in case you dont believe me ;-)

Attachments (1)

Screenshot.jpg (149.1 KB) - added by phaensch@… 11 years ago.
screenshot, demonstrating the described problem

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by Tom Hughes

Priority: criticalminor

Sure it's easy to insert that line, but then we're not respecting the user's chosen background colour anymore. There is no easy solution here I think.

By the way, who are these mysterious "guys at openstreetmap" and why is it more awkward for them than anybody else?

Changed 11 years ago by phaensch@…

Attachment: Screenshot.jpg added

screenshot, demonstrating the described problem

comment:2 in reply to:  1 ; Changed 11 years ago by Hugh Barnes

Keywords: stylesheet colour usability accessibility added; color black background foreground removed
Owner: changed from Tom Hughes to Hugh Barnes
Status: newassigned

Replying to tom@compton.nu:

Sure it's easy to insert that line, but then we're not respecting the user's chosen background colour anymore. There is no easy solution here I think.

You're not respecting their foreground at the moment. Neither or both!

I'm going to grab this one, since it's a nice easy starting point for me if you accept what I'm saying. Else reject the commit and we'll debate some more.

(and can I ask why you're setting the various link states all to the same colour?)

comment:3 in reply to:  2 Changed 11 years ago by Tom Hughes

Replying to awesm:

(and can I ask why you're setting the various link states all to the same colour?)

Well you'd have to ask whoever did it (hint, it probably wasn't me). There is no royal "you" here - what you see is the result of the uncoordinated actions by a large number of people over a period of several years.

Plus we tend to prioritise something that works for 99.99% of people over getting every last nuance fixed first time out - we fix the details as we find them.

comment:4 Changed 11 years ago by Hugh Barnes

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.