Opened 11 years ago

Closed 8 years ago

#1271 closed defect (fixed)

[PATCH] Mapnik renders jewish cemeteries with crosses

Reported by: ipofanes Owned by: mapnik-team@…
Priority: minor Milestone:
Component: mapnik Version:
Keywords: Cc:

Attachments (6)

grave_yard_tombsone.png (255 bytes) - added by nigelbee 10 years ago.
tombstone for forming cemetery pattern
grave_yard+.png (263 bytes) - added by Mariusz Adamski 9 years ago.
Reworked tombstone
grave_yard++.png (480 bytes) - added by Mariusz Adamski 9 years ago.
Inspired by the Unicode 26FC graveyard symbol
generic_grave_yard_cemetery.patch (1.0 KB) - added by claudius.h@… 9 years ago.
Patch for mapnik style to include generic cemetery icon and specific jewish+christian ones
grave_yard_generic.png (1013 bytes) - added by claudius.h@… 9 years ago.
Generic grave_yard/cemetery icon
generic_grave_yard_cemetery-fixed.patch (1.1 KB) - added by Mariusz Adamski 9 years ago.
Fixed generic cemetaries patch

Download all attachments as: .zip

Change History (19)

comment:1 Changed 10 years ago by nigelbee

This has been fixed for the Osmarender layer, so I suggest Mapnik uses the same logic.

The Mapnik rule:

   <Rule>
      <MaxScaleDenominator>50000</MaxScaleDenominator>
      <Filter>[landuse] = 'cemetery' or [landuse] = 'grave_yard'</Filter>
      <PolygonPatternSymbolizer file= "c:/mapnik/symbols/grave_yard.png" type="png" width="16" height="16"/>
    </Rule>

needs to be replaced with:

    <Rule>
      <MaxScaleDenominator>50000</MaxScaleDenominator>
      <Filter>([landuse] = 'cemetery' or [landuse] = 'grave_yard') and [religion] = 'christian'</Filter>
      <PolygonPatternSymbolizer file= "c:/mapnik/symbols/grave_yard.png" type="png" width="16" height="16"/>
    </Rule>
    <Rule>
      <MaxScaleDenominator>50000</MaxScaleDenominator>
      <Filter>([landuse] = 'cemetery' or [landuse] = 'grave_yard') and [religion] &lt;&gt; 'christian'</Filter>
      <PolygonPatternSymbolizer file= "c:/mapnik/symbols/grave_yard_tombstone.png" type="png" width="16" height="16"/>
    </Rule>

I have attached the grave_yard_tombsote.png file (which I have converted from the Osmarender SVG format into the Mapnik png format).

Changed 10 years ago by nigelbee

Attachment: grave_yard_tombsone.png added

tombstone for forming cemetery pattern

comment:2 Changed 10 years ago by nigelbee

Owner: changed from steve8@… to nigelbee
Status: newassigned

comment:3 Changed 10 years ago by nigelbee

Owner: changed from nigelbee to steve8@…
Status: assignednew

comment:4 Changed 9 years ago by Ldp

Owner: changed from steve8@… to mapnik-team@…

comment:5 Changed 9 years ago by ralmin

I hope someone can fix this soon - I have mapped an Islamic cemetery, which I tagged as religion=muslim. It should appear with crescents or at least a non-religious tombstone, but certainly not with crosses.

comment:6 Changed 9 years ago by Ldp

See #2949 for the addition of the Magen David symbol. Still need to address the generic symbol, but the headstone motif doesn't come out nearly as nice and recognizable as the cross.

The attachment here is too pale compared to the cross/magen david background. The headstone has about the same colour as buildings, which also makes it look out of place on the map: looks like a field which is full of headstone-formed buildings, not good.

Changed 9 years ago by Mariusz Adamski

Attachment: grave_yard+.png added

Reworked tombstone

Changed 9 years ago by Mariusz Adamski

Attachment: grave_yard++.png added

Inspired by the Unicode 26FC graveyard symbol

comment:7 Changed 9 years ago by Mariusz Adamski

I have two other symbols for consideration (see attachments). The first one is inspired by the original tombstone, but the background is now identical to the pattern used currently. It is also slightly lighter, to avoid confusion with buildings. Second one is inspired by the Unicode 26FC graveyard symbol.

I would like to point out, that whether or not a symbol is "recognizable" is an opinion. Recognition of symbols is unfortunately closely tied with a cultural background of a person doing recognition. Finding a culture-neutral graveyard symbol is difficult, since those places are often closely linked with religion. We have to make a compromise, that is to choose a symbol, which would be equally (even if poorly) recognized by everyone, instead of favouring one particular group.

Changed 9 years ago by claudius.h@…

Patch for mapnik style to include generic cemetery icon and specific jewish+christian ones

Changed 9 years ago by claudius.h@…

Attachment: grave_yard_generic.png added

Generic grave_yard/cemetery icon

comment:8 Changed 9 years ago by claudius.h@…

Summary: Mapnik renders jewish cemeteries with crosses[PATCH] Mapnik renders jewish cemeteries with crosses

Added a patch that shows a new attachment:"grave_yard_generic.png" pattern icon for all cemeteries/grave_yards *except* religion=christian (current cross pattern) or religion=jewish (current star of david pattern).

I've removed "not [religion] &lt;&gt; " from the rule as it should show the new generic graveyard fill pattern because it should show for any cemetery and not only for those with any religion set.

comment:9 Changed 9 years ago by claudius.h@…

Example map link to a muslim cemetery: http://osm.org/go/zY1sf3fLh-

Changed 9 years ago by Mariusz Adamski

Fixed generic cemetaries patch

comment:10 Changed 9 years ago by Mariusz Adamski

I finally managed to setup mapnik to do some testing, and it seems your version of osm.xml doesn't render cemeteries without religion tag above zoom 14. I fixed it modifying the logic in osm.xml.

comment:11 Changed 9 years ago by Ldp

not [religion] &lt;&gt; => This actually means "religion is NULL", aka it will match when there is no religion=* key present. That's why the original patch didn't work for those cases.

Your fix actually renders some graveyards twice, overwriting the generic with christian/jewish when it's one of those two.

I have committed a version of this patch that uses SQL to handle this, and also make it easier to add other religion symbols without needing more and more 'if not religion is such or so or this or that' in the filter for the generic case.

comment:13 Changed 8 years ago by Ldp

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.