Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

[PATCH] Mapnik renders jewish cemeteries with crosses #1271

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 9 comments
Closed

[PATCH] Mapnik renders jewish cemeteries with crosses #1271

openstreetmap-trac opened this issue Jul 23, 2021 · 9 comments

Comments

@openstreetmap-trac
Copy link

Reporter: ipofanes
[Submitted to the original trac issue database at 10.56am, Thursday, 16th October 2008]

http://www.openstreetmap.org/browse/way/27498802

see also

http://wiki.openstreetmap.org/index.php/Tag:landuse%3Dcemetery

@openstreetmap-trac
Copy link
Author

Author: nigelbee
[Added to the original trac issue at 7.29pm, Saturday, 10th January 2009]

This has been fixed for the Osmarender layer, so I suggest Mapnik uses the same logic.

The Mapnik rule:

   <Rule>
      <MaxScaleDenominator>50000</MaxScaleDenominator>
      <Filter>[landuse] = 'cemetery' or [landuse] = 'grave_yard'</Filter>
      <PolygonPatternSymbolizer file= "c:/mapnik/symbols/grave_yard.png" type="png" width="16" height="16"/>
    </Rule>

needs to be replaced with:

    <Rule>
      <MaxScaleDenominator>50000</MaxScaleDenominator>
      <Filter>([landuse] = 'cemetery' or [landuse] = 'grave_yard') and [religion] = 'christian'</Filter>
      <PolygonPatternSymbolizer file= "c:/mapnik/symbols/grave_yard.png" type="png" width="16" height="16"/>
    </Rule>
    <Rule>
      <MaxScaleDenominator>50000</MaxScaleDenominator>
      <Filter>([landuse] = 'cemetery' or [landuse] = 'grave_yard') and [religion] &lt;&gt; 'christian'</Filter>
      <PolygonPatternSymbolizer file= "c:/mapnik/symbols/grave_yard_tombstone.png" type="png" width="16" height="16"/>
    </Rule>

I have attached the grave_yard_tombsote.png file (which I have converted from the Osmarender SVG format into the Mapnik png format).

@openstreetmap-trac
Copy link
Author

Author: ralmin
[Added to the original trac issue at 9.24am, Monday, 5th April 2010]

I hope someone can fix this soon - I have mapped an [http://www.openstreetmap.org/?lat=-34.866254&lon=138.537993&zoom=18&layers=B000FTF Islamic cemetery], which I tagged as religion=muslim. It should appear with crescents or at least a non-religious tombstone, but certainly not with crosses.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 2.19am, Monday, 24th May 2010]

See #2949 for the addition of the Magen David symbol. Still need to address the generic symbol, but the headstone motif doesn't come out nearly as nice and recognizable as the cross.

The attachment here is too pale compared to the cross/magen david background. The headstone has about the same colour as buildings, which also makes it look out of place on the map: looks like a field which is full of headstone-formed buildings, not good.

@openstreetmap-trac
Copy link
Author

Author: Mariusz Adamski
[Added to the original trac issue at 7.27pm, Sunday, 18th July 2010]

I have two other symbols for consideration (see attachments). The first one is inspired by the original tombstone, but the background is now identical to the pattern used currently. It is also slightly lighter, to avoid confusion with buildings. Second one is inspired by the Unicode 26FC graveyard symbol.

I would like to point out, that whether or not a symbol is "recognizable" is an opinion. Recognition of symbols is unfortunately closely tied with a cultural background of a person doing recognition. Finding a culture-neutral graveyard symbol is difficult, since those places are often closely linked with religion. We have to make a compromise, that is to choose a symbol, which would be equally (even if poorly) recognized by everyone, instead of favouring one particular group.

@openstreetmap-trac
Copy link
Author

Author: claudius.h[at]gmx.de
[Added to the original trac issue at 2.11pm, Monday, 19th July 2010]

Added a patch that shows a new attachment:"grave_yard_generic.png" pattern icon for all cemeteries/grave_yards except religion=christian (current cross pattern) or religion=jewish (current star of david pattern).

I've removed "not [religion] <> ''" from the rule as it should show the new generic graveyard fill pattern because it should show for any cemetery and not only for those with any religion set.

@openstreetmap-trac
Copy link
Author

Author: claudius.h[at]gmx.de
[Added to the original trac issue at 2.27pm, Monday, 19th July 2010]

Example map link to a muslim cemetery: http://osm.org/go/zY1sf3fLh-

@openstreetmap-trac
Copy link
Author

Author: Mariusz Adamski
[Added to the original trac issue at 12.49pm, Monday, 2nd August 2010]

I finally managed to setup mapnik to do some testing, and it seems your version of osm.xml doesn't render cemeteries without religion tag above zoom 14. I fixed it modifying the logic in osm.xml.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 12.04am, Tuesday, 3rd August 2010]

not [religion] <> '' => This actually means "religion is NULL", aka it will match when there is no religion=* key present. That's why the original patch didn't work for those cases.

Your fix actually renders some graveyards twice, overwriting the generic with christian/jewish when it's one of those two.

I have committed a version of this patch that uses SQL to handle this, and also make it easier to add other religion symbols without needing more and more 'if not religion is such or so or this or that' in the filter for the generic case.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 12.08am, Tuesday, 3rd August 2010]

r22545, r22546

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant