Opened 11 years ago

Closed 9 years ago

#1316 closed enhancement (fixed)

Direction of road not displayed

Reported by: Nybbler Owned by: Chris Browet
Priority: minor Milestone:
Component: merkaartor Version:
Keywords: Cc: merkaartor@…

Description

The direction of a road or the orientation of an area is not visible. This way you don't know if a oneway street is pointing in the correct direction or if an area is including or excluding water.

Change History (12)

comment:1 Changed 11 years ago by Chris Browet

Not true for oneway roads, definitely. There must be something else, please include a screenshot.

AFAIK, the "direction" of an area do not influence the inclusion/exclusion thing. It's the "inner/outer" role on the relation that does that.

But I can be wrong. Please point me to some info on the wiki if I am.

comment:2 Changed 10 years ago by Chris Browet

Owner: changed from cbro@… to Chris Browet
Status: newassigned
Type: defectenhancement

comment:3 Changed 10 years ago by Chris Browet

Accepted

comment:4 Changed 10 years ago by Chris Browet

Resolution: fixed
Status: assignedclosed

(In [12188]) ADD : "View" - "Show directional Arrows" menu. "Never" obviously never shows the arrows, "Always" obviously always shows them, even for non-roads. "Oneway" is the equivalent of the existing and is the default. (closes #1316)

comment:5 Changed 10 years ago by Colin Marquardt

Resolution: fixed
Status: closedreopened

I'm not convinced about this preference. I would have expected that setting to be available in the style editor: highway=* would get a setting of "oneway", waterway=* and maybe a ski piste etc. would get "always", and all the other ones "never".

If you still want to let the user display arrows all the time or never, this could be selected in the Preferences dialog, but filling up the limited menu space seems unnecessary.

comment:6 Changed 10 years ago by Colin Marquardt

Ok, coastlines should also always get arrows, but my point still stands.

comment:7 Changed 10 years ago by Chris Browet

Cc: merkaartor@… added

I don't think this belong to the style editor. As pointed out by this reporter and the other, this is especially (only?) useful for technical reasons (coastlines, river banks).

As such, I put it in the menu because I think this is a settings you would only occasionally set, for short-time, very specific editing. I agree this clutters the menu, however I rather consider the preferences dialog to be for "long-term" preferences. I'm very open to other UI suggestions you might have.

OTOH, I definitely agree a similar "long-term" setting should appear in the style editor (for roads, ...). While working on this, I noticed there is a setting in the .mas files, not editable thru the editor.

comment:8 in reply to:  7 Changed 10 years ago by Colin Marquardt

Replying to koying:

OTOH, I definitely agree a similar "long-term" setting should appear in the style editor (for roads, ...). While working on this, I noticed there is a setting in the .mas files, not editable thru the editor.

Yes, but it's not possible to set that setting to "always". As a mental note, natural=cliff should also get that "always" setting since it's direction dependent without being a oneway road.

comment:9 Changed 10 years ago by Nybbler

Just a note: I initially submitted this bug because there is no direction arrow when the road has "highway=road" (which is drawn as a very thin line, which I also find annoying). So when the road is residential/secondary/... the arrows are visible.

comment:10 in reply to:  9 ; Changed 10 years ago by Colin Marquardt

Replying to Nybbler:

Just a note: I initially submitted this bug because there is no direction arrow when the road has "highway=road" (which is drawn as a very thin line, which I also find annoying). So when the road is residential/secondary/... the arrows are visible.

Ah. So the setting of drawTrafficDirectionMarks should be "yes" by default, i.e. when the style doesn't override it. In your specific case, I assume you are using the classic style? Since that doesn't have a definition for "highway=road", it does show up unstyled. Is switching to Mapnik(Plus) an option? I could also add a highway=road to Classic.mas, but I'd rather it was fixed in the code.

comment:11 in reply to:  10 Changed 10 years ago by Nybbler

Replying to ColinMarquardt:

Replying to Nybbler:

Just a note: I initially submitted this bug because there is no direction arrow when the road has "highway=road" (which is drawn as a very thin line, which I also find annoying). So when the road is residential/secondary/... the arrows are visible.

Ah. So the setting of drawTrafficDirectionMarks should be "yes" by default, i.e. when the style doesn't override it. In your specific case, I assume you are using the classic style? Since that doesn't have a definition for "highway=road", it does show up unstyled. Is switching to Mapnik(Plus) an option? I could also add a highway=road to Classic.mas, but I'd rather it was fixed in the code.

Ah, I never thought about switching the style. Yes, with MapnikPlus? I can see arrows now. Fine for me now.

comment:12 Changed 9 years ago by Chris Browet

Resolution: fixed
Status: reopenedclosed

Original bug solved, I guess

Note: See TracTickets for help on using tickets.