Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Allow canvas background to be set from a style #1333

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Closed

Allow canvas background to be set from a style #1333

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

Reporter: ColinMarquardt
[Submitted to the original trac issue database at 10.45pm, Thursday, 13th November 2008]

I thought I had filed this ticket before, but can't find it... so here it goes.

I just committed a style called Lighting which displays ways with the lit=yes tag in a yellow color. In order to create the illusion of a "night mode", it would be nice if the style could set the color of the canvas background. Right now, this is a global user setting.

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 11.44am, Thursday, 11th December 2008]

(In [12293]) ADD : Allow canvas background to be set from a style. Background color is still overridable in the global preferences. (closes #1333)

@openstreetmap-trac
Copy link
Author

Author: ColinMarquardt
[Added to the original trac issue at 6.33pm, Friday, 12th December 2008]

Thanks very much, I updated Lighting.mas accordingly. There is one problem with it however: when you had Lighting selected and switch back to another style which doesn't have the background color defined, it stays like it was. Is this the intended behavior? If so, then I'd need to add the background setting to all of the styles. No problem, but it would not cover styles people use only locally.

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 7.06pm, Friday, 12th December 2008]

The truth is I just didn't thought about this case.

Definitely, it should revert to the pref defined background.

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 7.39pm, Friday, 12th December 2008]

(In [12311]) FIX : revert to preferences background when switching style and no background is defined in the new style (fixes #1333)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant