Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Changeset timestamp stuff appears to break Potlatch & Potlatch #1350

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: Richard
[Submitted to the original trac issue database at 10.56pm, Tuesday, 18th November 2008]

Creating a new changeset doesn't work any more:

[2008-11-20 11:23:58.455368 #24653] NoMethodError (You have a nil object when you didn't expect it!
You might have expected an instance of Array.
The error occurred while evaluating nil.-):
/app/models/changeset.rb:140:in save_with_tags!' /Library/Ruby/Gems/1.8/gems/activerecord-2.1.2/lib/active_record/connection_adapters/abstract/database_statements.rb:66:in transaction'
/Library/Ruby/Gems/1.8/gems/activerecord-2.1.2/lib/active_record/transactions.rb:79:in transaction_without_deadlock_handling' /vendor/plugins/deadlock_retry/lib/deadlock_retry.rb:45:in transaction'
/app/models/changeset.rb:136:in save_with_tags!' /app/controllers/amf_controller.rb:158:in startchangeset'

Potlatch code is from line 149 of amf_controller.rb.

@openstreetmap-trac
Copy link
Author

Author: smsm1
[Added to the original trac issue at 2.37pm, Thursday, 20th November 2008]

This issue is not specific to Potlatch, as JOSM has the same problem.

@openstreetmap-trac
Copy link
Author

Author: smsm1
[Added to the original trac issue at 9.23pm, Thursday, 20th November 2008]

(In [12011]) Closes #1350 through updating amf_controller to use the newer closed_at method of determining whether a changeset is closed. Richard please check the rest of the amf controller for more things that may reference the open field that is no longer available. Use is_open? to determine if a changeset is open. Fix indentation in amf controller. Fix minor bug in the links to changesets in the data brower.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant