putpoi needs to send current version back to the server from the swf for checking the commit #1376
Comments
Author: smsm1 putway needs it too |
Author: smsm1 putpoi, putway, and putrelation are getting an additional parameter version after the changeset. |
Author: smsm1 that version parameter is the current version of the node/way/relation that was downloaded from the db. Should have the refactoring of amf controller finished tomorrow afternoon. |
Author: smsm1 The refactoring has been implemented in r12223 and r12232. |
Author: Richard We need to be a bit clever about what to do when a conflict is detected (e.g. Potlatch originally received version 3, has just sent version 4, but the object on the server is already at version 4/5/whatever). In particular, amf_controller needs to send back:
If any of the conflicting changes were made by another user, we have a classical edit conflict. However, if they were all made by the current user, this usually indicates that amf_controller carried out a previous write in this session, but that Potlatch never received the response (very common in times of high server load). In that case we do not have a conflict and Potlatch should update its UI and internal data accordingly. |
Author: smsm1 deleteway needs the version number and id for the way and all nodes. The server will then decide which nodes are unshared and need deleted. Take a look at putrelation. It has a series of rescues, including |
Author: Richard Am re-refactoring putway, will probably need to do deleteway and some others as well. This isn't going to be a whole host of fun. |
Author: smsm1 If you need any help let me know. |
Author: Richard Think this is all done now. |
Reporter: smsm1
[Submitted to the original trac issue database at 12.08am, Wednesday, 3rd December 2008]
There may be other places that the swf needs to send the version back to the server for validation.
The text was updated successfully, but these errors were encountered: