Opened 11 years ago

Closed 11 years ago

#1395 closed defect (fixed)

Diary entry allows invalid lat/long

Reported by: Gregory Williams Owned by: Thomas Wood
Priority: minor Milestone: OSM 0.6
Component: api Version:
Keywords: Cc:

Description

(1) Create a diary entry with an invalid lat/long (e.g 1000, 2000).

Expected: Error telling me that the lat/long isn't valid. Perhaps I've made a typo? Actual: Accepts diary entry.

Attachments (4)

diary.patch (828 bytes) - added by Thomas Wood 11 years ago.
diary_validations.patch (843 bytes) - added by Thomas Wood 11 years ago.
and validations for the above (& more)
diary_validations.2.patch (1.0 KB) - added by Thomas Wood 11 years ago.
revis
diary_validations.3.patch (1.1 KB) - added by Thomas Wood 11 years ago.
another revision, adjusted function name to be more logical, added 255 char test

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 years ago by Thomas Wood

Owner: changed from Tom Hughes to Thomas Wood
Status: newassigned

Patch prepared on local machine, awaiting SVN access to commit.

Changed 11 years ago by Thomas Wood

Attachment: diary.patch added

Changed 11 years ago by Thomas Wood

Attachment: diary_validations.patch added

and validations for the above (& more)

Changed 11 years ago by Thomas Wood

Attachment: diary_validations.2.patch added

revis

Changed 11 years ago by Thomas Wood

Attachment: diary_validations.3.patch added

another revision, adjusted function name to be more logical, added 255 char test

comment:2 Changed 11 years ago by edgemaster

Resolution: fixed
Status: assignedclosed

(In [12370]) Add validations for diary entry lat/lons and tests for diary entry validations. Closes #1395

Note: See TracTickets for help on using tickets.