Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1417 closed defect (fixed)

getDefaultLanguage() returns an invalid value

Reported by: Łukasz Jernaś Owned by: cbro@…
Priority: major Milestone:
Component: merkaartor Version:
Keywords: review Cc: deejay1@…

Description

getDefaultLanguage() returns an invalid value if the UI language is taken from the environment (LANG,LC_ALL, etc variables) and the because of that tag values in the tag templates aren't translated properly. Proposed patch attached, if it's OK I'll apply it to svn

Attachments (1)

locale.patch (980 bytes) - added by Łukasz Jernaś 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Łukasz Jernaś

Attachment: locale.patch added

comment:1 Changed 10 years ago by Łukasz Jernaś

After some thoughHHHsleep I've noticed that this won't work with locales like en_GB. One possible solution would be to check first for the complete locale name, eg "pl_PL" and then for the language part "pl"...

comment:2 Changed 10 years ago by Chris Browet

Resolution: fixed
Status: newclosed

(In [13206]) FIX : getDefaultLanguage() returns an invalid value with 2-parts language definition (like en_GB) (by Lukasz Jernas) (closes #1417)

comment:3 Changed 10 years ago by Łukasz Jernaś

Erm, as I said before - this patch doesn't cover most relevant cases and needs some additional work...

Note: See TracTickets for help on using tickets.