Opened 11 years ago

Closed 11 years ago

#1451 closed defect (fixed)

Delay on unselecting objects

Reported by: LonelyPixel Owned by: cbro@…
Priority: minor Milestone:
Component: merkaartor Version:
Keywords: Cc:

Description

When you have selected a node/way/anything and click on an empty space on the map to unselect them, it takes a few seconds until it's unselected and the application continues to react on user input. This is a very frustrating thing when working with many objects and often selecting something different.

I found out that access to the QSettings instance is relatively slow. This was done for every object in all visible layers when deselecting objects. Since preferences access does not depend on any loop variable, I have moved the prefs access outside of that loop. Now there's no noticeable delay left.

Since the QSettings class is a Qt class and it stores settings into the registry on Windows (which is a thing not to be found on other platforms), I assume that this bug is platform-dependent any may not be visible on Linux/OSX. It is visible on Windows though and this patch fixes it.

Attachments (1)

EditInteraction.cpp.diff (914 bytes) - added by LonelyPixel 11 years ago.
Patch of my proposed implementation

Download all attachments as: .zip

Change History (2)

Changed 11 years ago by LonelyPixel

Attachment: EditInteraction.cpp.diff added

Patch of my proposed implementation

comment:1 Changed 11 years ago by LonelyPixel

Resolution: fixed
Status: newclosed

Fixed in Changeset 13050: Cache preferences values for quicker access

Note: See TracTickets for help on using tickets.