Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1459 closed defect (fixed)

Don't jump around on Download More

Reported by: LonelyPixel Owned by: cbro@…
Priority: minor Milestone:
Component: merkaartor Version:
Keywords: Cc:

Description

I personally think that it's a bad idea, when more OSM data shall be downloaded, to alter the map and the viewport at the same time. This is what happens right now. When you're running out of loaded data and want to load some more, that map contents change. But if that wasn't enough, the view on the map also changes to something smaller. So at first, you lose any orientiation and need to zoom in again to where you have just been, to continue what you have just done.

This patch simply disables the single line of code that does that jump. It's also a much better experience to see the map features actually appear in the same place where none/few have been before. You get what you want, where you want it. Ideal user feedback.

Attachments (1)

DownloadOSM.cpp.diff (447 bytes) - added by LonelyPixel 10 years ago.
Patch of my proposed implementation

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by LonelyPixel

Attachment: DownloadOSM.cpp.diff added

Patch of my proposed implementation

comment:1 Changed 10 years ago by LonelyPixel

Resolution: fixed
Status: newclosed

Implemented in Changeset 13075

comment:2 Changed 10 years ago by LonelyPixel

The jumping also occurs when you go to the Preferences dialogue and press OK or Apply. It always zooms one level out then. Simply changing adjustLayers(true) to adjustLayers(false) in MainWindow::preferencesChanged() is no solution, though, as it will then zoom out really far instead. There seems to be a more general issue with setViewport() that somehow computes the wrong zoom value to set, or something.

Note: See TracTickets for help on using tickets.