Ticket #1462 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Sort tags list when selecting an object

Reported by: LonelyPixel Owned by: cbro@…
Priority: major Milestone:
Component: merkaartor Version:
Keywords: Cc:

Description

One of the most annoying things to me in Merkaartor is that when I select two objects (one after another) to compare their tags, they always are in a different order. It's hard to tell quickly whether they have the same tags and values assigned. The only solution to this is to sort the tags in the list. This is what my patch does. It may not be the most efficient sorting algorithm, in fact it's the first I was thinking of, to sort the items in-place. It is working fine for me, I could not determine any data corruption in a small test and it doesn't lead to a sensible delay. (How could that be for a list of < 10 items...)

Maybe this could be improved by applying a certain pre-defined order different from the lexical. For example: highway < service < name < maxspeed < * < note < created_by. That would be more of an order by importance first, then tag name.

Attachments

TagModel.cpp.diff Download (793 bytes) - added by LonelyPixel 5 years ago.
Patch of my proposed implementation

Change History

Changed 5 years ago by LonelyPixel

Patch of my proposed implementation

comment:1 Changed 5 years ago by richardbrinkman

  • Status changed from new to closed
  • Resolution set to fixed

(In [13218]) FIX : Sort tags list when selecting an object (fixes #1462)

Note: See TracTickets for help on using tickets.