Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

RTL text word-wraps in reverse order #1515

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 29 comments
Closed

RTL text word-wraps in reverse order #1515

openstreetmap-trac opened this issue Jul 23, 2021 · 29 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Esperanza36
[Submitted to the original trac issue database at 10.50pm, Tuesday, 20th January 2009]

There is a problem with Arabic names rendering on Mapnik, only for areas, like hospitals, public buildings, parks names ... and not for street names.

Words are correctly rendered, but they are not in the good order (last are first).
For instance here : http://www.openstreetmap.org/?lat=31.42411&lon=34.33985&zoom=15&layers=B000FTF

(good one)

is on OSM the contrary

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 10.30am, Wednesday, 21st January 2009]

I've just looked at that link at it appears to be rendering in the way you say is correct - it is rendered as " " at the moment. Are you seeing something different?

@openstreetmap-trac
Copy link
Author

Author: Esperanza36
[Added to the original trac issue at 10.34pm, Wednesday, 21st January 2009]

No, first we must have (refugee camp)
then (deir) and last (al balah) on the second line of :
http://www.openstreetmap.org/?lat=31.42411&lon=34.33985&zoom=15&layers=B000FTF
So words are not in the right place

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 1.01pm, Thursday, 22nd January 2009]

In that case I think the problem is that the tagging is wrong. If I look at that node in my web browser by going to http://www.openstreetmap.org/browse/node/327387610 then my browser renders it (in both the name and name:ar tags) as " " but you seem to be saying it should be the other way round?

So is my browser also getting the rendering wrong? or are you saying it should be rendered differently on the map to when written as a string?

@openstreetmap-trac
Copy link
Author

Author: Esperanza36
[Added to the original trac issue at 4.43pm, Thursday, 22nd January 2009]

The tag is ok : http://www.openstreetmap.org/browse/node/327387610
name:ar =

The problem is that on the first line on mapnik rendering (no problem with osmander)
we should have

and not

On the second line instead of

we should have

I use Mozilla ...

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 4.46pm, Thursday, 22nd January 2009]

OK. So what you're saying is that the words on the map should be rendered in a different order to the words when written as a string? Why is that?

Is the issue that there is a line break and that in arabic you read lines from bottom to top rather than top to bottom?

@openstreetmap-trac
Copy link
Author

Author: Esperanza36
[Added to the original trac issue at 5.53pm, Thursday, 22nd January 2009]

In Arabic, we read lines from top to bottom ;)
The bug happens only when there is lines, not when it's one line (street names, ...)

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 5.56pm, Thursday, 22nd January 2009]

Aha... I get it now... This is a mapnik problem though, so it will need to be raised in the mapnik trac as it isn't something in our code base that is wrong.

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 6.27pm, Thursday, 22nd January 2009]

I have raised this in the mapnik trac as http://trac.mapnik.org/ticket/189.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 10.55pm, Saturday, 15th August 2009]

#2182 has been marked as duplicate of this ticket.

@openstreetmap-trac
Copy link
Author

Author: jahudie[at]gmail.com
[Added to the original trac issue at 9.46pm, Monday, 27th December 2010]

It is really about time to take care of this issue.
Just imagine that we would write "Kingdom United" instead of "United Kingdom"
It would be fixed right away.

Please check if you could fix this bug somehow that was opened.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 3.55pm, Tuesday, 28th December 2010]

As I explained in the previous comment, this is not something we have have any control over - it is an issue with the mapnik software we use to render the map.

We have reported the issue upstream so if you want to moan (which would be bad form anyway for Open Source Software) then you should do so at http://trac.mapnik.org/ticket/189 as moaning here will achieve nothing.

@openstreetmap-trac
Copy link
Author

Author: dimka
[Added to the original trac issue at 11.51am, Friday, 5th August 2011]

I've submitted a "quick and dirty" patch upstream.

Can it be incorporated in the main OSM mapnik layer?

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 9.35pm, Friday, 5th August 2011]

Only if/when it is fixed upstream, and in due time.

Submitting a "quick and dirty" patch upstream isn't going to magically make everything alright in the main OSM mapnik layer all by itself and overnight. It's currently still at 0.7.2-dev, so any fixes in trunk will be off limits until such a time we switch over to mapnik trunk.

Nevertheless, thanks for taking a look at fixing this upstream.

@openstreetmap-trac
Copy link
Author

Author: dimka
[Added to the original trac issue at 5.56pm, Tuesday, 9th August 2011]

Replying to [comment:15 Ldp]:

Only if/when it is fixed upstream, and in due time.

Submitting a "quick and dirty" patch upstream isn't going to magically make everything alright in the main OSM mapnik layer all by itself and overnight. It's currently still at 0.7.2-dev, so any fixes in trunk will be off limits until such a time we switch over to mapnik trunk.

Nevertheless, thanks for taking a look at fixing this upstream.

I hope that when the mapnik team finishes all the necessary tests, the patch can be incorporated into the 0.7 line and not wait for the Mapnik2 release. In that case, will it be possible to update the downstream version of mapnik running on the main OSM site?

Please understand that this is a very annoying bug - people see many labels messed up the first time they open OSM.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 5.58pm, Tuesday, 9th August 2011]

Getting it in to 0.7 is supremely irrelevant as I believe we have been running mapnik 2 for some time now,

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 7.42pm, Tuesday, 9th August 2011]

Replying to [comment:17 TomH]:

Getting it in to 0.7 is supremely irrelevant as I believe we have been running mapnik 2 for some time now,

Correct, but I've falsely assumed it would need a stylesheet element to activate, and in that case, our 0.7- style XML is still relevant. Upon reviewing the patch, it seems that's not needed. This would mean we could get the patch active on osm.org once it's accepted into mapnik trunk.

@openstreetmap-trac
Copy link
Author

Author: dimka
[Added to the original trac issue at 8.01pm, Sunday, 25th September 2011]

The patch has just been committed to Mapnik trunk (http://trac.mapnik.org/changeset/3365).

@openstreetmap-trac
Copy link
Author

Author: dimka
[Added to the original trac issue at 9.31pm, Tuesday, 4th October 2011]

Please consider applying the patch.

@openstreetmap-trac
Copy link
Author

Author: Esperanza36
[Added to the original trac issue at 4.17pm, Wednesday, 23rd November 2011]

Please consider applying the patch. This bug is VERY annoying for my arabs friends. Thanks in advance

@openstreetmap-trac
Copy link
Author

Author: amire80
[Added to the original trac issue at 6.11pm, Saturday, 4th February 2012]

Now this also affects the official Mobile Wikipedia app, which is switching from Google to OSM.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 7.26pm, Saturday, 4th February 2012]

Replying to [comment:23 amire80]:

Now this also affects the official Mobile Wikipedia app, which is switching from Google to OSM.

Then the persons making that Mobile Wikipedia app can fix it by upgrading their mapnik, right?

@openstreetmap-trac
Copy link
Author

Author: dimka
[Added to the original trac issue at 9.20pm, Tuesday, 13th March 2012]

No change is apparent on OSM.org

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 10.09pm, Tuesday, 13th March 2012]

Replying to [comment:26 dimka]:

No change is apparent on OSM.org

That's because the mapnik version there hasn't been updated yet, but I understand the good mapnik folks hope to have a new release soon.

@openstreetmap-trac
Copy link
Author

Author: mariotomo
[Added to the original trac issue at 12.18pm, Monday, 24th September 2012]

any news? when is mapnik scheduled to be updated on OSM?

http://osm.org/go/btJRqQa5Y--
(above map shows "/ and /")

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 12.20pm, Monday, 24th September 2012]

We plan to reload the rendering database in the next few weeks with an ODBL clean planet, and I believe Jon plans to upgrade mapnik at the same time.

@openstreetmap-trac
Copy link
Author

Author: sdoerr
[Added to the original trac issue at 11.24am, Thursday, 17th January 2013]

Replying to [comment:29 TomH]:

We plan to reload the rendering database in the next few weeks with an ODBL clean planet,
and I believe Jon plans to upgrade mapnik at the same time.

Did this happen? The word-wrap issue with Arabic still seems to be there, e.g. (currently in the news) [http://www.openstreetmap.org/browse/node/2072091143 In Amenas].

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 11.26am, Thursday, 17th January 2013]

Not yet no, it is still in the planning stages as it is a major update of software and hardware.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 1.24pm, Friday, 18th October 2013]

The reload was done a few months ago - could you check if this is now fixed?

@openstreetmap-trac
Copy link
Author

Author: yrtimid[at]gmail.com
[Added to the original trac issue at 3.00pm, Friday, 18th October 2013]

The hebrew word-wrap looks good now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant