Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Multipolygon: Inner holes don't render in some case #1650

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Closed

Multipolygon: Inner holes don't render in some case #1650

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Claas Augner
[Submitted to the original trac issue database at 3.04pm, Saturday, 14th March 2009]

This problem occurs, for example, with one of the Black Forest's relations:
http://www.openstreetmap.org/browse/relation/5838

See map section: http://www.openstreetmap.org/?lat=48.82285&lon=8.56215&zoom=15 (Mapnik doesn't render, while Osmarender does)

The holes were, however, rendered properly (then only in Mapnik) until December 2008.


I have just noticed another multipolygon nearby that is handled quite oddly by Mapnik:
http://www.openstreetmap.org/browse/relation/8443

See map section: http://www.openstreetmap.org/?lat=48.56336&lon=8.10763&zoom=16 (Mapnik renders a hole with small forest areas within according to JOSM validator incorrect , but none of the holes around; this time Osmarender doesn't render any hole).

@openstreetmap-trac
Copy link
Author

Author: Claas Augner
[Added to the original trac issue at 12.14pm, Saturday, 28th March 2009]

Meanwhile Osmarender renders the second example properly as well, whereas Mapnik still doesn't.

@openstreetmap-trac
Copy link
Author

Author: jburgess777[at]googlemail.com
[Added to the original trac issue at 10.11pm, Sunday, 10th May 2009]

This should be fixed by an update I made to osm2pgsql this weekend which makes it ignore the orientation of the polygon rings. We will need to wait until the weekly import on Wednesday to be sure it works for these examples.

@openstreetmap-trac
Copy link
Author

Author: jburgess777[at]googlemail.com
[Added to the original trac issue at 11.12pm, Tuesday, 19th May 2009]

It looks like the holes are rendering OK until a diff makes an update to the relation. I have applied a fix to osm2pgsql in r15118 which should fix this case too.

@openstreetmap-trac
Copy link
Author

Author: jburgess777[at]googlemail.com
[Added to the original trac issue at 10.23pm, Thursday, 21st May 2009]

The 5838 relation now seems to be rendering correctly, but you need to use the export tab to see it at the moment.

The final fix was an error in the tagging, the name=Schwarzwald tag was on the relation instead of the outer way. This prevented osm2pgsql from migrating the landuse=forest tag from the outer way on to the multipolygon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant