Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Potlatch tests #1761

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 1 comment
Closed

Potlatch tests #1761

openstreetmap-trac opened this issue Jul 23, 2021 · 1 comment

Comments

@openstreetmap-trac
Copy link

Reporter: Richard
[Submitted to the original trac issue database at 5.06pm, Sunday, 26th April 2009]

smsm1 RichardF: if you run the tests you'll get the list of errors like on http://cruise.shaunmcdonald.me.uk/builds/osmapi-postgres/14758
[17:51:51]smsm1 RichardF: for the failing test test_whichways_badlat
[17:53:07]smsm1 RichardF: you'll see the code at http://trac.openstreetmap.org/browser/sites/rails_port/test/functional/amf_controller_test.rb#L106
[17:53:24]smsm1 RichardF: the failing test is an assertion at line 144
[17:54:38]smsm1 RichardF: it looks like you have customised the boundary error, to be more specific
[17:55:50]smsm1 RichardF: so changing that error message will be required
[17:56:35]RichardF smsm1: cool - when I've got the db working and have got the urgent Potlatch stuff done then I can take a look at that
[17:57:47]smsm1 RichardF: due to the customisation of the error message, it also looks like you will need to duplicate that test method based on whether the min and max lat is the right way around.
smsm1 http://trac.openstreetmap.org/browser/sites/rails_port/test/functional/amf_controller_test.rb#L106


@openstreetmap-trac
Copy link
Author

Author: grand.edgemaster[at]gmail.com
[Added to the original trac issue at 8.58pm, Friday, 1st May 2009]

In [14866], fixed the failing tests, but I do note that there are more tests with # TODO warnings on, still to be fixed by someone with more idea of what potlatch does :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant