Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Data browser doesn't number relation members correctly #1764

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

Data browser doesn't number relation members correctly #1764

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Richard
[Submitted to the original trac issue database at 9.56am, Monday, 27th April 2009]

It just doesn't.

http://www.openstreetmap.org/browse/way/32797402

0?!

@openstreetmap-trac
Copy link
Author

Author: ed[at]loach.me.uk
[Added to the original trac issue at 11.39am, Monday, 27th April 2009]

Another example:
http://www.openstreetmap.org/browse/node/343568398
This is the first item in relation 15020 and the sequence numbering starts at 124277. I suspect this is why I can't add to or remove from the relation (preconditions_ok? fails).

@openstreetmap-trac
Copy link
Author

Author: edgemaster
[Added to the original trac issue at 9.26pm, Monday, 27th April 2009]

(In [14791]) Quick fix to reference relation rather than relation_member when linking to the relation, not sure when the bug was introduced. Tests still need to be written for the browse controller.
Closes #1764

@openstreetmap-trac
Copy link
Author

Author: grand.edgemaster[at]gmail.com
[Added to the original trac issue at 10.15pm, Monday, 27th April 2009]

Replying to [comment:1 ed[at]loach.me.uk]:

Another example:
http://www.openstreetmap.org/browse/node/343568398
This is the first item in relation 15020 and the sequence numbering starts at 124277. I suspect this is why I can't add to or remove from the relation (preconditions_ok? fails).
Nope, this bug was only as a result of using the wrong object id when linking out to relations. Much of the user-facing website code doesn't have testing functions written yet.
However, I don't think another manifestation of this issue would impact on any of the API-side code, since the method in question does not rely on the reverse lookup of element to relation, but rely directly on the relation's members.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant