Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1764 closed defect (fixed)

Data browser doesn't number relation members correctly

Reported by: Richard Owned by: Tom Hughes
Priority: major Milestone:
Component: website Version:
Keywords: data_browser Cc:

Description

Change History (3)

comment:1 Changed 10 years ago by ed@…

Another example: http://www.openstreetmap.org/browse/node/343568398 This is the first item in relation 15020 and the sequence numbering starts at 124277. I suspect this is why I can't add to or remove from the relation (preconditions_ok? fails).

comment:2 Changed 10 years ago by edgemaster

Resolution: fixed
Status: newclosed

(In [14791]) Quick fix to reference relation rather than relation_member when linking to the relation, not sure when the bug was introduced. Tests still need to be written for the browse controller. Closes #1764

comment:3 in reply to:  1 Changed 10 years ago by Thomas Wood

Replying to ed@loach.me.uk:

Another example: http://www.openstreetmap.org/browse/node/343568398 This is the first item in relation 15020 and the sequence numbering starts at 124277. I suspect this is why I can't add to or remove from the relation (preconditions_ok? fails).

Nope, this bug was only as a result of using the wrong object id when linking out to relations. Much of the user-facing website code doesn't have testing functions written yet. However, I don't think another manifestation of this issue would impact on any of the API-side code, since the method in question does not rely on the reverse lookup of element to relation, but rely directly on the relation's members.

Note: See TracTickets for help on using tickets.