Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

The way and relation models raise "invalid placeholder" errors without an OSM::API error wrapper #1770

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 1 comment

Comments

@openstreetmap-trac
Copy link

Reporter: tom[at]compton.nu
[Submitted to the original trac issue database at 11.11am, Tuesday, 28th April 2009]

The way and relation models raise "invalid placeholder" errors without an OSM::API error wrapper so the errors are not trapped and reported to the user but instead just lead to a "500 Internal Server Error" response.

@openstreetmap-trac
Copy link
Author

Author: Matt
[Added to the original trac issue at 10.10am, Wednesday, 29th April 2009]

fixed three places in the code where a "raw" raise was used, converted instead to OSM::APIError types. also made these error messages more informative by giving the element ID and the missing placeholder ID so that the user or client can deal with them more effectively. added a couple of tests to changeset_controller_tests to check that these are being enforced and the correct error messages are being returned. see r14814.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant