Opened 10 years ago

Closed 10 years ago

#1770 closed defect (fixed)

The way and relation models raise "invalid placeholder" errors without an OSM::API error wrapper

Reported by: Tom Hughes Owned by: Tom Hughes
Priority: minor Milestone:
Component: api Version:
Keywords: Cc:

Description

The way and relation models raise "invalid placeholder" errors without an OSM::API error wrapper so the errors are not trapped and reported to the user but instead just lead to a "500 Internal Server Error" response.

Change History (1)

comment:1 Changed 10 years ago by Matt

Resolution: fixed
Status: newclosed

fixed three places in the code where a "raw" raise was used, converted instead to OSM::APIError types. also made these error messages more informative by giving the element ID and the missing placeholder ID so that the user or client can deal with them more effectively. added a couple of tests to changeset_controller_tests to check that these are being enforced and the correct error messages are being returned. see r14814.

Note: See TracTickets for help on using tickets.