Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1777 closed enhancement (fixed)

Show 'name' attribute in browser links where available

Reported by: Dan Karran Owned by: Thomas Wood
Priority: major Milestone:
Component: website Version:
Keywords: Cc:

Description

Where an object in the browser section of the site has a name attribute, it would be good to display this as part of the link (along with the ID and version number) to allow users to see at a glance where named objects have are referenced.

For example, in changeset 602388, the way 33279387 would be labeled 'Knighton Avenue' in the list of ways it includes, and in node 14564609 the ways it belongs to ('Churchfield Lane', 'Woodstock Avenue', 'Glentworth Road'), would have their names displayed instead of just their IDs.

Attachments (1)

data_browser_labels.patch (11.5 KB) - added by Thomas Wood 10 years ago.
second patch to actually do the changeset pages, as well as everything else

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by Dan Karran

Perhaps it would also be good to include the ref in brackets if available.

comment:2 Changed 10 years ago by Thomas Wood

Owner: changed from Tom Hughes to Thomas Wood
Status: newassigned

Yes, I'm a +1 to this, to match the behaviour of the data layer.

Changed 10 years ago by Thomas Wood

Attachment: data_browser_labels.patch added

second patch to actually do the changeset pages, as well as everything else

comment:3 Changed 10 years ago by Thomas Wood

Before I commit to trunk, I would like some views on how I've formatted the appearance of id #/version # details.

The proposed patch is applied to the test API at http://main.dev.openstreetmap.org/browse/changeset/453 (it uses same database and account details as api06.dev.)

comment:4 Changed 10 years ago by Thomas Wood

Oh, I've not made the suggested change to how the node is displayed, it simply looks for the name tag on the node, rather than the intersecting ways for now.

comment:5 Changed 10 years ago by edgemaster

(In [14872]) Data browser changes, make links more user friendly, displaying name tag where possible. Changes to models ok'd (and suggested as temporary solution) by TomH References #1777

comment:6 Changed 10 years ago by Tom Hughes

Resolution: fixed
Status: assignedclosed

Change now deployed.

comment:7 Changed 10 years ago by Dan Karran

Thanks guys, it looks good.

Note: See TracTickets for help on using tickets.