Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1816 closed defect (fixed)

changesets are auto-closed 1hour after creation despite of younger edits

Reported by: xylome Owned by: Tom Hughes
Priority: minor Milestone: OSM 0.6
Component: api Version:
Keywords: changeset auto-close Cc:

Description says:

  • To avoid stale open changesets a mechanism is implemented to automatically close changesets upon one of the following three conditions:
    • More than 50.000 edits on a single changeset See more specific limits
    • The changeset has been open for more than 24 hours
    • There have been no changes/API calls related to a changeset in 1 hour (i.e. idle timeout)

currently changesets are always auto-closed 1 hour after their creation.

i haven't checked the 50.000 edits limit ;-), but the 1 hour timer seems to always override the 24 hour timer.

Change History (7)

comment:1 Changed 10 years ago by Tom Hughes

You haven't said what editor you are using... Potlatch did have a bug that caused it to not extend the close time when an edit was made but that should be fixed now.

Perhaps if you have the ID of a changeset that you think was wrongly handled we could have a look at it?

comment:2 Changed 10 years ago by xylome

this has nothing to do with a special client. i'm experiencing this behaviour with a bot running more than 1 hour. its opening the changeset as soon as it make its first update to an object and has to open a new changeset every hour as it gets a 409 error message. its no real problem, but there is an unecessary amount of changesets originating from the same editing session and the updates are not kept together in one changeset (which i thought was the main cause for adding changesets to api0.6)

far as i understand the api documentation in the wiki, the changeset should stay open 1 hour after the last edit of an object, just like the bounding box is expanded by every object edited (no active process by the client)

comment:3 Changed 10 years ago by Tom Hughes

I asked for the ID of an example changeset so I can investigate, but apparently you don't actually want to help us find the problem, you'd rather just repeat yourself.

I have not at any point denied that there may be a problem. I have simply (in the absence of any clue as to which api methods you were using) explained about one know problem in this area that was recently fixed and asked for your help in tracking down that problem.

If you don't want to give me an example then at least tell me which API methods you are using - are you doing diff uploads or making old style calls to add/change/delete individual objects?

comment:5 Changed 10 years ago by xylome

the api functions used are:

  • PUT /api/0.6/changeset/create
  • PUT /api/0.6/[node|way|relation]/#id
  • PUT /api/0.6/changeset/#id/close

i'm not using the POST /api/0.6/changeset/#id/upload method.

comment:6 Changed 10 years ago by Tom Hughes

Resolution: fixed
Status: newclosed

Fixed in r15023.

comment:7 Changed 10 years ago by xylome

Summary: changesets are auto-closed after 1hour after creation despite of younger editschangesets are auto-closed 1hour after creation despite of younger edits

confirm: Fix is working

Note: See TracTickets for help on using tickets.