Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Turn URLs in tag values into links in the data browser #1855

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Closed

Turn URLs in tag values into links in the data browser #1855

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Assignees
@openstreetmap-trac
Labels
Component: website Priority: minor Resolution: fixed Type: enhancement

Comments

@openstreetmap-trac
Copy link

Reporter: dan[at]karran.net
[Submitted to the original trac issue database at 1.29pm, Sunday, 24th May 2009]

A number of tags often hold URLs to related information (e.g. many linking to wikipedia entries) but these aren't converted into links when browsing the data through the browser pages (e.g. [http://www.openstreetmap.org/browse/node/283519523 Castletown]). It'd be nice if these could be converted into links to assist users (and search engines).

I appreciate there could be some concerns about spam when automatically linking anything, so perhaps this ought to be restricted to http://*.wikipedia.org/* links for now?
@openstreetmap-trac openstreetmap-trac self-assigned this Jul 23, 2021
@openstreetmap-trac
Copy link
Author

Author: dan[at]karran.net
[Added to the original trac issue at 10.18pm, Tuesday, 26th May 2009]

Adding a quick patch to turn all URLs in tag values into links. Does it also need to be passed through sanitize(), and should it be any more restrictive, or should we be as trusting here as we are in people's profiles and diary entries?

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 10.48pm, Tuesday, 26th May 2009]

If you're going to get rid of the h() invocation (and I think you have to drop that) then yes, you absolutely must run it through sanitize instead.

To be clear to anybody else reading this ticket, this patch MUST NOT be committed as it currently stands.

@openstreetmap-trac
Copy link
Author

Author: dan[at]karran.net
[Added to the original trac issue at 11.42pm, Wednesday, 27th May 2009]

Updated patch attached.

@openstreetmap-trac
Copy link
Author

Author: tomhughes
[Added to the original trac issue at 11.27am, Saturday, 30th May 2009]

(In [15329]) Make links in tags active in the data browser. Fixes #1855.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@openstreetmap-trac openstreetmap-trac

Labels
Component: website Priority: minor Resolution: fixed Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openstreetmap-trac