Tidy up coordinates on diary entries #1872
Comments
Author: smsm1 Personally I think that it would be better to store them to a more reasonable number of decimal places, rather than making the view code messier. |
Author: grand.edgemaster[at]gmail.com I'd lean the other way from shaun and keep the stored numbers at the current precision, and change the patch to pass all digits in the links, rather than cropping them to 4dp. (But keep the displayed digits at 4dp) |
Author: dan[at]karran.net I'm sort of somewhere in between. When people are using the map to set the coordinates, I doubt we need to give them all those dp, so maybe limit the default. Perhaps limit that through js, but let them enter a more precise figure if they really want to? Then we display a fixed amount, but link them through to what was entered originally. Bit of a compromise? Updated patch attached. |
Author: grand.edgemaster[at]gmail.com I was going to add that it should be possible to reuse the code we use for creating permalinks of a number of decimal places appropriate to the zoom level viewed. |
Author: grand.edgemaster[at]gmail.com The code I was thinking of was
Which is currently embedded into the top of the updatelinks function of site.js. |
Author: TomH As of r20184 we now display a reverse geocoded description of the location rather than the raw coordinates. |
Author: dankarran Much better than my original proposal, thanks Tom. |
Reporter: dan[at]karran.net
[Submitted to the original trac issue database at 9.35pm, Tuesday, 26th May 2009]
The coordinates that show on diary entries are a little unwieldy, and I believe unnecessarily so. The attached patch tidies them up a little by limiting the display of them to 4 decimal places.
The text was updated successfully, but these errors were encountered: