Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1916 closed task (fixed)

Legend shown at openstreetmap.org does not adapt to basemap and is not translatable

Reported by: ToB Owned by: Tom Hughes
Priority: minor Milestone:
Component: website Version:
Keywords: Cc:

Description

Goto http://www.openstreetmap.org/, click on "Legend" in the middle of left sidebar and you get the following legend shown: http://www.openstreetmap.org/images/keymapnik15.png

Expected:

a) If you choose a different base map, the a different legend is shown

b) The language of www.openstreetmap.org matches the language shown in the legend

Attachments (1)

osm-keys.tar.gz (9.6 KB) - added by ToB 10 years ago.
All PNGs needed for Mapnik's key map + a PHP script (English+German labels), which needs to be converted for osm.org

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by Tom Hughes

Priority: majorminor

Please don't put multiple problems on one ticket - it makes the ticket impossible to close.

As far as layers goes, as soon as somebody gives me a key for one of the other layers I can start displaying it. To date only the creators of the mapnik layer have bothered to do this.

As far as translation goes, we are aware that this is an issue but there is no easy solution at the moment as the key is an image.

Changed 10 years ago by ToB

Attachment: osm-keys.tar.gz added

All PNGs needed for Mapnik's key map + a PHP script (English+German labels), which needs to be converted for osm.org

comment:2 Changed 10 years ago by avar

Fixed in changeset [16073] and [16074].

comment:3 Changed 10 years ago by avar

Resolution: fixed
Status: newclosed

comment:4 Changed 10 years ago by Tom Hughes

Did you do what I repeatedly asked and talk to Jon Burgess and/or Steve8 before making this change?

comment:5 Changed 10 years ago by Tom Hughes

Having just looked at what you committed, it is clearly completely insane so will not be being deployed in it's current state.

comment:6 in reply to:  5 Changed 10 years ago by avar

Replying to tom@compton.nu:

Did you do what I repeatedly asked and talk to Jon Burgess and/or Steve8 before making this change?

I asked Jon Burgess what he thought and he doesn't think he's the best person to offer advice about the style of implementation of features in the railsport.

Having just looked at what you committed, it is clearly completely insane so will not be being deployed in it's current state.

What about it is insane? Dynamically generating HTML with JavaScript?? The feature already depends on JS. And the load of serving individual PNG files is negligable as they will be cached on the browser side.

But maybe you have completely different objections. So it would help to get specific objections in the first place and not have to speculate as to what it is that you mean. Mindreading is not one of my many talents.

Note: See TracTickets for help on using tickets.