Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1920 closed enhancement (fixed)

/message/new/:user_id should be /message/new/:display_name

Reported by: avar Owned by: Tom Hughes
Priority: trivial Milestone:
Component: website Version:
Keywords: Cc:

Description

It would be shiny from a UI perspective if the user name was displayed in the url as opposed to user id. The attached patch is a work in progress which doesn't work (and I'm dumping it in trac so I don't forget it), I get this error on message send:

1 error prohibited this Message from being saved

There were problems with the following fields:

    * Sender is invalid

But the @user and @to_user objects are created successfully, hrm...

It also throws NoMethodError? in new.rhtml when visiting /message/new/USER_DOES_NOT_EXIST

Attachments (1)

message-new-user_id-to-display_name.patch (3.2 KB) - added by avar 10 years ago.
Incomplete non-working patch

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by avar

Incomplete non-working patch

comment:1 Changed 10 years ago by edgemaster

Resolution: fixed
Status: newclosed

(In [16011]) Commit avar's patch (+ fix for user not found) to change message sending URL to be by user name rather than id. (Closes #1920)

comment:2 Changed 10 years ago by edgemaster

(via-IRC) non-workingness discovered to be due to custom patch against user model to allow user@localhost emails. Initial patch worked fine on a clean install.

Note: See TracTickets for help on using tickets.