Opened 10 years ago

Closed 10 years ago

#1921 closed defect (fixed)

Escape doublequotes in pl translation file to fix Potlatch.

Reported by: balrog-kun Owned by: Łukasz Jernaś
Priority: major Milestone:
Component: website Version:
Keywords: potlatch, flash, javascript Cc:

Description

Apparently the pl.yml prevents the "edit" tab from working because flash is not detected because of a javascript syntax error. That's because we used doublequotes in the potlatch_unsaved_changes string translation, and the strings gets inserted into generated javascript as-is.

Attached patch escapes the doublequotes (let's hope that's enough to make it work). Also attaching my patch from #1912 to fix typos in the translation and update to current en.yml.

Attachments (2)

pl.yml-escape-doublequotes.diff (1.2 KB) - added by balrog-kun 10 years ago.
Escape doublequotes in potlatch_unsaved_changes.
pl.yml.diff (11.4 KB) - added by balrog-kun 10 years ago.
A bunch of fixes.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by balrog-kun

Escape doublequotes in potlatch_unsaved_changes.

Changed 10 years ago by balrog-kun

Attachment: pl.yml.diff added

A bunch of fixes.

comment:1 Changed 10 years ago by Tom Hughes

I've committed the first patch to get potlatch working.

comment:2 Changed 10 years ago by Łukasz Jernaś

Resolution: fixed
Status: newclosed

Second patch commited. In the future please wait a bit or mail me/antblant before attaching a second patch to an other bug - I just got real life, so I cannot commit changes immediately. Or even better - use osm.srem.org and the wonderfull post-review tool to commit your proposals so we can discuss them there...

Note: See TracTickets for help on using tickets.