Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Escape doublequotes in pl translation file to fix Potlatch. #1921

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Comments

@openstreetmap-trac
Copy link

Reporter: balrog-kun
[Submitted to the original trac issue database at 7.10pm, Friday, 5th June 2009]

Apparently the pl.yml prevents the "edit" tab from working because flash is not detected because of a javascript syntax error. That's because we used doublequotes in the potlatch_unsaved_changes string translation, and the strings gets inserted into generated javascript as-is.

Attached patch escapes the doublequotes (let's hope that's enough to make it work). Also attaching my patch from #1912 to fix typos in the translation and update to current en.yml.

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 10.57pm, Friday, 5th June 2009]

I've committed the first patch to get potlatch working.

@openstreetmap-trac
Copy link
Author

Author: deejay1
[Added to the original trac issue at 9.12am, Saturday, 6th June 2009]

Second patch commited. In the future please wait a bit or mail me/antblant before attaching a second patch to an other bug - I just got real life, so I cannot commit changes immediately. Or even better - use osm.srem.org and the wonderfull post-review tool to commit your proposals so we can discuss them there...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant