Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

potlatch ignores keyboard commands #1935

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Closed

potlatch ignores keyboard commands #1935

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Assignees
@openstreetmap-trac
Labels
Component: potlatch (flash editor) Priority: major Resolution: wontfix Type: defect

Comments

@openstreetmap-trac
Copy link

Reporter: pgf
[Submitted to the original trac issue database at 1.13pm, Monday, 8th June 2009]

<pgf> RichardF_: i should mention an odd behavior i had with potlatch this morning:
<pgf> RichardF_: after editing last night, and having the server refuse my updates, my changeset eventually timed out.

[ this was due to #1904, btw. ]

<pgf> RichardF_: after that happened, potlatch seemed to refuse to honor keystrokes.
<pgf> i could commence an edit (e.g., start a new way) but not cancel it with ESC.
<pgf> nor could i delete points with Delete.
<pgf> i could however do all the usual things with the mouse.
<pgf> again, this is really just fyi...

i had been working in "Save" mode at the time, and my upload had been refused repeatedly.
i also tried Saving again after the changeset timed out. not sure at exactly what point the described behavior started.
@openstreetmap-trac openstreetmap-trac self-assigned this Jul 23, 2021
@openstreetmap-trac
Copy link
Author

Author: raffourtit[at]gmail.com
[Added to the original trac issue at 7.16pm, Monday, 10th August 2009]

Potlatch Started ignoring key commands during undelete actions.

using: Windows XP Home SP3, Firefox 3.5.2, Flash 10,0,22,87, Potlatch 1.2

I suspect it is some Ctrl + action that triggers this.

@openstreetmap-trac
Copy link
Author

Author: NE2
[Added to the original trac issue at 3.16pm, Wednesday, 10th March 2010]

Every time I've had this happen, it's been after one or more internal dialog boxes such as "you are zoomed out really far; would you like to zoom in?" and "this way has a conflict; would you like to download or overwrite?". It seems to happen eventually if enough of these pop up, but the number is highly variable.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 3.26pm, Wednesday, 10th March 2010]

Yes, it is indeed something to do with the internal dialogue boxes.

Potlatch basically needs to know where to direct keypresses. If a dialogue box is open, it won't send keypresses through to the main editor, for obvious reasons (you don't want to be typing 'g' in a textfield and have the GPS tracks load, or something). It does this by counting the number of dialogues on screen (line 694 of potlatch.as) and only acting on keypresses if there are none.

Unfortunately it seems to sometimes think there are dialogues on screen when there aren't. I haven't figured out why yet. As ever, steps to reproduce would be hugely useful.

@openstreetmap-trac
Copy link
Author

Author: iandees
[Added to the original trac issue at 7.40pm, Monday, 9th September 2013]

Cleaning aging tickets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@openstreetmap-trac openstreetmap-trac

Labels
Component: potlatch (flash editor) Priority: major Resolution: wontfix Type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openstreetmap-trac