Opened 11 years ago

Closed 11 years ago

#1966 closed defect (fixed)

old style viewport handling

Reported by: Olivier Berten Owned by: Chris Browet
Priority: major Milestone:
Component: merkaartor Version:
Keywords: Cc:


In MainWindow?.cpp you can find on line 2026 theView->projection().viewport() instead of theView->viewport() which prevents compiling with option OSMARENDER=1

Change History (6)

comment:1 Changed 11 years ago by Chris Browet

Are you actually using Osmarender?

I was planning to remove support for it for a while and now is as good a time as another...

comment:2 Changed 11 years ago by axk

just stumbled over this. i have no opinion re: removing osmarender support (i never used it, but neither do i use merkaartor a lot), but this issue should be resolved. one way (changing theView->projection().viewport() to theView->viewport() at line 2037 (r16035)), or removing osmarender support (including in the doc wiki). thank you!

comment:3 Changed 11 years ago by Chris Browet

Owner: changed from cbro@… to Chris Browet
Priority: blockermajor
Status: newassigned

Right, but for the moment, the obvious solution is to not enable the OSMARENDER=1 option in qmake/Config.pri!

comment:4 Changed 11 years ago by axk

it's obvious once make reaches MainWindow.cpp and after you debugged and svn-blamed and googled for an hour and came here :)

comment:5 Changed 11 years ago by Chris Browet

Err... Those are the risks of using a svn version (and copy/pasting examples from the wiki without wondering if you need the option;-)

Will be solved within the day.

comment:6 Changed 11 years ago by Chris Browet

Resolution: fixed
Status: assignedclosed

(In [16039]) CHG : Remove support for osmarender (fixes #1966)

Note: See TracTickets for help on using tickets.