Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

old style viewport handling #1966

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments
Closed

old style viewport handling #1966

openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Olivier Berten
[Submitted to the original trac issue database at 4.41am, Tuesday, 16th June 2009]

In MainWindow.cpp you can find on line 2026
theView->projection().viewport()
instead of
theView->viewport()
which prevents compiling with option OSMARENDER=1

@openstreetmap-trac
Copy link
Author

Author: Koying
[Added to the original trac issue at 3.26pm, Tuesday, 16th June 2009]

Are you actually using Osmarender?

I was planning to remove support for it for a while and now is as good a time as another...

@openstreetmap-trac
Copy link
Author

Author: axk
[Added to the original trac issue at 10.52am, Monday, 22nd June 2009]

just stumbled over this. i have no opinion re: removing osmarender support (i never used it, but neither do i use merkaartor a lot), but this issue should be resolved. one way (changing theView->projection().viewport() to theView->viewport() at line 2037 (r16035)), or removing osmarender support (including in the doc wiki). thank you!

@openstreetmap-trac
Copy link
Author

Author: Koying
[Added to the original trac issue at 11.04am, Monday, 22nd June 2009]

Right, but for the moment, the obvious solution is to not enable the OSMARENDER=1 option in qmake/Config.pri!

@openstreetmap-trac
Copy link
Author

Author: axk
[Added to the original trac issue at 12.46pm, Monday, 22nd June 2009]

it's obvious once make reaches MainWindow.cpp and after you debugged and svn-blamed and googled for an hour and came here :)

@openstreetmap-trac
Copy link
Author

Author: Koying
[Added to the original trac issue at 1.55pm, Monday, 22nd June 2009]

Err... Those are the risks of using a svn version (and copy/pasting examples from the wiki without wondering if you need the option;-)

Will be solved within the day.

@openstreetmap-trac
Copy link
Author

Author: koying
[Added to the original trac issue at 2.31pm, Monday, 22nd June 2009]

(In [16039]) CHG : Remove support for osmarender (fixes #1966)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant