Opened 9 years ago

Last modified 7 years ago

#2063 assigned task

Write test to verify that you cannot upload tags with ascii control chars

Reported by: smsm1 Owned by: smsm1
Priority: major Milestone:
Component: api Version:
Keywords: Cc:

Description

You shouldn't be able to put ascii control characters into the OSM database, as it can break the diffs.

http://lists.openstreetmap.org/pipermail/dev/2009-July/016153.html

Change History (4)

comment:1 Changed 9 years ago by smsm1

Via the AMF Controller. There are some unicode chars that are not valid in XML.

comment:2 Changed 9 years ago by Richard

This may actually be a ming fuckup, see http://bugs.libming.org/show_bug.cgi?id=88 .

Potlatch has historically stopped you entering 0x00-0x1F. Unfortunately the code to do this is newly broken in latest Ming. At the weekend I needed to commit some Potlatch stuff on a machine that only had the latest Ming installed, so had to temporarily remove the check.

Will recompile with Ming 0.3 asap.

comment:3 Changed 9 years ago by smsm1

  • Status changed from new to assigned

We'll need to add that check to Rails too, in the AMF controller where the strings are read. We don't need to do this on the nwr models, as the XML parser automatically does this check for us, thus would just slow things down unnecessarily.

comment:4 Changed 7 years ago by TomH

  • Component changed from admin to api
Note: See TracTickets for help on using tickets.