Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Write test to verify that you cannot upload tags with ascii control chars #2063

Open
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: smsm1
[Submitted to the original trac issue database at 10.47pm, Monday, 13th July 2009]

You shouldn't be able to put ascii control characters into the OSM database, as it can break the diffs.

http://lists.openstreetmap.org/pipermail/dev/2009-July/016153.html

@openstreetmap-trac
Copy link
Author

Author: smsm1
[Added to the original trac issue at 10.08am, Tuesday, 14th July 2009]

Via the AMF Controller. There are some unicode chars that are not valid in XML.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 10.24am, Tuesday, 14th July 2009]

This may actually be a ming fuckup, see http://bugs.libming.org/show_bug.cgi?id=88 .

Potlatch has historically stopped you entering 0x00-0x1F. Unfortunately the code to do this is newly broken in latest Ming. At the weekend I needed to commit some Potlatch stuff on a machine that only had the latest Ming installed, so had to temporarily remove the check.

Will recompile with Ming 0.3 asap.

@openstreetmap-trac
Copy link
Author

Author: smsm1
[Added to the original trac issue at 10.33am, Tuesday, 14th July 2009]

We'll need to add that check to Rails too, in the AMF controller where the strings are read. We don't need to do this on the nwr models, as the XML parser automatically does this check for us, thus would just slow things down unnecessarily.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant