Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#2087 closed defect (fixed)

Way browsig with slovenian locale is failing

Reported by: StefanB Owned by: Tom Hughes
Priority: major Milestone:
Component: website Version:
Keywords: Cc:

Description

http://www.openstreetmap.org/browse/way/27028715 throws an error, but doesn't show enough info to fix it without seeing the logs.

My old ubuntu laptop with all the needed setup died so i can't reproduce this locally in near future.

I fixed the suspected interpolation error in [16596], but am not sure if this is already deployed or there is some other problem.

This issue is a spinoff of #2079.

Change History (8)

comment:1 Changed 10 years ago by StefanB

Component: adminwebsite

comment:2 Changed 10 years ago by Tom Hughes

It's browse.way_details.also_part_of that is the problem. I've added bogus versions of the 'two' and 'few' subkeys in r16613 that will need to be translated properly.

comment:3 Changed 10 years ago by StefanB

Thank you for fixing it. Pluralization in that context is ok as it is, so it could probably be removed all together (all plural forms are the same in this context in our strange language).

One could think that ":other" would handle all other (not specifically translated ) forms. I guess i18n mechanism could be more robust after all :)

comment:4 Changed 10 years ago by Tom Hughes

Well we can fix the custom pluralizer to fall back to :other if you want...

comment:5 Changed 10 years ago by StefanB

Well, there are also cases in English where one would want eg:

:zero

:other

plural forms, but this isn't handled properly by i18n plugin afaik.

It sure would be nice to have this supported, specially with so many plural forms as we have (and which are the same in some circumstances). I'm not sure how our simple custom pluralizer could know what translations it has before picking one...

comment:6 Changed 10 years ago by Tom Hughes

The :zero one is optional - if you don't have it then it uses :other instead. That is handled specially for all languages before invoking the language specific pluralizer (which is why I removed the :zero handling from your one).

I'll have a look at whether the custom pluralizer can be made to do fallback...

comment:7 Changed 10 years ago by Tom Hughes

Resolution: fixed
Status: newclosed

Fixed in r16633.

comment:8 Changed 10 years ago by StefanB

witty!

When i was translating i18n plugin i went for .rb instead of .yml in hopes that also sl pluralization could go in there, so that it is all in one place, not spread in several files across plugin, making it easier for others to reuse and possibly not getting lost with plugin upgrades.

Note: See TracTickets for help on using tickets.