Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Accept Header detection needs improvement #2088

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Accept Header detection needs improvement #2088

openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments

Comments

@openstreetmap-trac
Copy link

Reporter: matti[at]mversen.de
[Submitted to the original trac issue database at 1.17pm, Tuesday, 21st July 2009]

The accept header parsing seems to be a little bit broken.
The website falls back to english with this headers :

de-at
de;q=0.8
en-us;q=0.5
en;q=0.3

or it also fails back to english with:
de
de-de;q=0.8
en-us;q=0.5
en;q=0.3

it works (german website displayed) with :

de-de
de;q=0.8
en-us;q=0.5
en;q=0.3

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 6.08pm, Tuesday, 21st July 2009]

This is when you're not logged in I assume (when you are logged in the HTTP headers are ignored in favour of your user preferences)?

Is your browser really space separating the languages? All the ones I've seen use a comma...

@openstreetmap-trac
Copy link
Author

Author: matti[at]mversen.de
[Added to the original trac issue at 5.48am, Wednesday, 22nd July 2009]

My issue is caused by my settings, i should have known it better, sorry !
Sorry also for the bad bug report, my used Browser is Seamonkey trunk from today (Gecko based) on win32.
The space is just from the website : http://browserspy.dk/accept.php that i used for see the send accept header, the real header looks like this:
Accept-Language: de,en;q=0.7,en-us;q=0.3[CRLF] (using http://web-sniffer.net )

I never touched my language field in my settings, i had this fields stored:
"de-DE,en-US,en,de" and that result is english while "de,de-DE,en-US,en" and "de-DE,de,,en-US,en" works and I get german.

marking invalid

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant