Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Mapnik: render icons on polygon POIs #2129

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments
Closed

Mapnik: render icons on polygon POIs #2129

openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments

Comments

@openstreetmap-trac
Copy link

Reporter: skunk
[Submitted to the original trac issue database at 8.05am, Tuesday, 4th August 2009]

Currently no icons are rendered on POIs which are entered as polygons, though they might get a different color, therefore many mappers enter a polygon AND a node, which should not happen (according to http://wiki.openstreetmap.org/wiki/Good_practice).

This is a patch to render icons and texts on polygons as well.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 2.54am, Monday, 10th August 2009]

Slightly cleaned up, now in r16952

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 12.46am, Wednesday, 19th August 2009]

It's now rendering. Thanks for the patch!

@openstreetmap-trac
Copy link
Author

Author: fiveisalive
[Added to the original trac issue at 3.46am, Saturday, 29th August 2009]

When this went live, it correctly rendered names as well as icons on polygon ways, such as libraries or churches, e.g.

Robbins Library in Arlington, MA, USA:

http://www.openstreetmap.org/browse/way/31495194

But I just converted a library point to a building and it rendered the icon correctly but seemed to omit the name, examples:

Cary Memorial Library in Lexington, MA, USA:

http://www.openstreetmap.org/browse/way/39710653

also a church:

http://www.openstreetmap.org/browse/way/39712986

has there been an additional change since this patch?

@openstreetmap-trac
Copy link
Author

Author: jburgess777[at]googlemail.com
[Added to the original trac issue at 9.29am, Monday, 31st August 2009]

There was a bug in this patch which meant that the text-poly layer was not rendering. The issue is that the text style has a filter which references the aeroway column but this is not returned by the text-poly layer. This was fixed in osm.xml r17346.

I have just updated the live rendering with this fix so the tiles should be fixed when they are rendered again.

@openstreetmap-trac
Copy link
Author

Author: fiveisalive
[Added to the original trac issue at 12.00pm, Monday, 31st August 2009]

I can confirm that this fix appears to work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant