Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Add mountain_pass render in Mapnik #2140

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 17 comments
Closed

Add mountain_pass render in Mapnik #2140

openstreetmap-trac opened this issue Jul 23, 2021 · 17 comments

Comments

@openstreetmap-trac
Copy link

Reporter: stefano.pedretti[at]gmail.com
[Submitted to the original trac issue database at 9.58am, Thursday, 6th August 2009]

As subject, this element is really important for hike.

I suggest to render from Z13 (so they could be still spotted in a map of a whole single day hike), from Z15 with names, and from Z16 with elevation (if available).
Should start from bridge template with a smaller or different coloured symbol.

Area with mountain_pass:
http://www.openstreetmap.org/?lat=46.0247&lon=10.4644&zoom=14&layers=B000FTF

Proposed icon:
http://trac.openstreetmap.org/changeset/6638

Wiki page:
[http://wiki.openstreetmap.org/wiki/Key:mountain_pass]

Thank you

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 3.59pm, Thursday, 6th August 2009]

Are you talking about mapnik or tiles@home here?

@openstreetmap-trac
Copy link
Author

Author: stefano.pedretti[at]gmail.com
[Added to the original trac issue at 6.18pm, Thursday, 6th August 2009]

Mapnik, as subject.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 6.34pm, Thursday, 6th August 2009]

Doh! I'll put it in the mapnik component then...

The icon won't be much help as mapnik can't really use those for linear features. It's not based on mapnik bridges anyway as those don't have splays at the end.

@openstreetmap-trac
Copy link
Author

Author: _al
[Added to the original trac issue at 5.20pm, Saturday, 21st August 2010]

@TomH: mountain_pass=yes is only valid for a node! So please do consider rendering an icon (together with name and ele). TIA!

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 5.24pm, Saturday, 21st August 2010]

Yes, but the proposed icon is directional so that it needs to be aligned to match the way it is part of and mapnik can't currently do that.

I don't actually work on the mapnik stylesheet anyway, I was just commenting on why it might be tricky.

@openstreetmap-trac
Copy link
Author

Author: lzhl
[Added to the original trac issue at 8.56pm, Wednesday, 17th November 2010]

I think that pass should be render as brown cross (in one style with natural=peak).

See these maps (russian and austrian):
http://wiki.openstreetmap.org/wiki/File:Mountain_pass_on_russian_topo_map.jpg
http://wiki.openstreetmap.org/wiki/File:Mountain_pass_on_austrian_map.jpg

Proposed pictogram:
http://wiki.openstreetmap.org/wiki/File:Proposed_pictogram_for_mountain_pass%3Dyes.png

Sample of render:
http://wiki.openstreetmap.org/wiki/File:Sample_of_render_mountain_pass%3Dyes_as_brown_cross.png

We taging with mountain=yes the highest point of pass but not part of way passing across mountain range (when pictogram like bridge be good). Also this pictogram look good regardless from the direction of way.

@openstreetmap-trac
Copy link
Author

Author: vladimir.vyskocil[at]wanadoo.fr
[Added to the original trac issue at 9.27am, Thursday, 10th March 2011]

I also agree that mountain_pass are very useful to have on the map. lzhl proposition looks good and easy to add, yes/no ?

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 11.55am, Thursday, 10th March 2011]

I completely missed this one. Yes, seems easy enough, although the cross won't be aligned to the pass direction.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 10.01pm, Thursday, 10th March 2011]

And of course we don't have the mountain_pass=* key in the rendering db. That makes it really hard to render.

@openstreetmap-trac
Copy link
Author

Author: vladimir.vyskocil[at]wanadoo.fr
[Added to the original trac issue at 12.16pm, Thursday, 17th March 2011]

Does this mean that it can be done or just that this key must be added to the import script of the rendering db ?

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 7.22pm, Thursday, 17th March 2011]

It cannot be done using the currently imported database, and we hadn't planned on adding mountain_pass=* to the upcoming import.

One-off tagging hierarchies are hard on the osm2pgsql schema. Any idea why this isn't just highway=mountain_pass ?

@openstreetmap-trac
Copy link
Author

Author: vladimir.vyskocil[at]wanadoo.fr
[Added to the original trac issue at 8.03am, Friday, 18th March 2011]

Sorry I don't know why it is like this, but taginfo :
http://taginfo.openstreetmap.de/keys/?key=mountain_pass#values
show that it's almost only tagged in this way.

I can't imagine that a such important map feature won't be rendered in the near feature. It is a very valuable information for driving usage of the map but also for hiking.

@openstreetmap-trac
Copy link
Author

Author: Ldp
[Added to the original trac issue at 9.21am, Friday, 18th March 2011]

I wasn't disputing the validity of showing mountain passes. Just indicating that currently we have no way to render them, since this tag hierarchy isn't imported into the rendering db yet. We could add it immediately if it was in one of the hierarchies (like highway) that was already in our db. Alas, this isn't the case.

So, we'll only be able to show mountain passes after the next full db import. The last one was about a year ago. A new one should happen soon.

@openstreetmap-trac
Copy link
Author

Author: datendelphin
[Added to the original trac issue at 11.49am, Friday, 14th October 2011]

The mountain_pass is still not rendered as far as I can see. As I have posted on the corresponding nominatim ticket #3655, it is quite limiting that it is neither displayed, nor found. It is an important feature in the alpine region. Please add it or someone tell us what to do to get it on the map.

Converting mountain_pass=yes to highway=mountain_pass seems a bit ridiculous to do just for one renderer. But it is a possibility I think.

@openstreetmap-trac
Copy link
Author

Author: ligfietser
[Added to the original trac issue at 7.51am, Monday, 21st October 2013]

mountain_pass=yes is after 4 years still not rendered

@openstreetmap-trac
Copy link
Author

Author: AnderOSM
[Added to the original trac issue at 10.18pm, Monday, 21st October 2013]

I would also like to insist on the idea that all maps I have ever used include the mountain passes. They are not only important for hiking - they are important references for geographic regions, road traffic...

@openstreetmap-trac
Copy link
Author

Author: pnorman
[Added to the original trac issue at 6.17am, Monday, 11th November 2013]

The "mapnik" component in trac is for the old XML-based openstreetmap.xml stylesheets which are not deployed on OpenStreetMap.org. Since June the default style on OpenStreetMap.org has been openstreetmap-carto, which has its own issue tracker at https://github.com/gravitystorm/openstreetmap-carto/issues.

I'm going to go ahead and close this issue as wontfix to avoid people being confused by it and commenting on it instead of somewhere where it will effect the rendering on osm.org. Closing it doesn't mean the issue won't be fixed in openstreetmap-carto, just that this ticket is against old unmaintained software that has been replaced and this ticket has zero chance of being resolved.

There is an openstreetmap-carto ticket requesting mountain passes be rendered gravitystorm/openstreetmap-carto#244, but please read the roadmap at https://github.com/gravitystorm/openstreetmap-carto#roadmap to understand what issues are an immediate priority.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant