Ticket #2140 (closed enhancement: wontfix)

Opened 5 years ago

Last modified 5 months ago

Add mountain_pass render in Mapnik

Reported by: stefano.pedretti@… Owned by: mapnik-team@…
Priority: major Milestone: Wishlist
Component: mapnik Version:
Keywords: mountain_pass Cc: _al, lzhl, datendelphin


As subject, this element is really important for hike.

I suggest to render from Z13 (so they could be still spotted in a map of a whole single day hike), from Z15 with names, and from Z16 with elevation (if available). Should start from bridge template with a smaller or different coloured symbol.

Area with mountain_pass: http://www.openstreetmap.org/?lat=46.0247&lon=10.4644&zoom=14&layers=B000FTF

Proposed icon:  http://trac.openstreetmap.org/changeset/6638

Wiki page:  http://wiki.openstreetmap.org/wiki/Key:mountain_pass

Thank you

Change History

comment:1 Changed 5 years ago by tom@…

Are you talking about mapnik or tiles@home here?

comment:2 Changed 5 years ago by stefano.pedretti@…

Mapnik, as subject.

comment:3 Changed 5 years ago by TomH

  • Owner changed from tom@… to steve8@…
  • Priority changed from major to minor
  • Component changed from admin to mapnik
  • Type changed from defect to enhancement

Doh! I'll put it in the mapnik component then...

The icon won't be much help as mapnik can't really use those for linear features. It's not based on mapnik bridges anyway as those don't have splays at the end.

comment:4 Changed 4 years ago by Ldp

  • Owner changed from steve8@… to mapnik-team@…

comment:5 Changed 4 years ago by _al

  • Cc _al added

@TomH: mountain_pass=yes is only valid for a node! So please do consider rendering an icon (together with name and ele). TIA!

comment:6 Changed 4 years ago by TomH

Yes, but the proposed icon is directional so that it needs to be aligned to match the way it is part of and mapnik can't currently do that.

I don't actually work on the mapnik stylesheet anyway, I was just commenting on why it might be tricky.

comment:7 Changed 3 years ago by lzhl

  • Cc lzhl added

I think that pass should be render as brown cross (in one style with natural=peak).

See these maps (russian and austrian):  http://wiki.openstreetmap.org/wiki/File:Mountain_pass_on_russian_topo_map.jpg  http://wiki.openstreetmap.org/wiki/File:Mountain_pass_on_austrian_map.jpg

Proposed pictogram:  http://wiki.openstreetmap.org/wiki/File:Proposed_pictogram_for_mountain_pass%3Dyes.png

Sample of render:  http://wiki.openstreetmap.org/wiki/File:Sample_of_render_mountain_pass%3Dyes_as_brown_cross.png

We taging with mountain=yes the highest point of pass but not part of way passing across mountain range (when pictogram like bridge be good). Also this pictogram look good regardless from the direction of way.

comment:8 Changed 3 years ago by vladimir.vyskocil@…

I also agree that mountain_pass are very useful to have on the map. lzhl proposition looks good and easy to add, yes/no ?

comment:9 Changed 3 years ago by Ldp

I completely missed this one. Yes, seems easy enough, although the cross won't be aligned to the pass direction.

comment:10 Changed 3 years ago by Ldp

And of course we don't have the mountain_pass=* key in the rendering db. That makes it really hard to render.

comment:11 Changed 3 years ago by vladimir.vyskocil@…

Does this mean that it can be done or just that this key must be added to the import script of the rendering db ?

comment:12 Changed 3 years ago by Ldp

It cannot be done using the currently imported database, and we hadn't planned on adding mountain_pass=* to the upcoming import.

One-off tagging hierarchies are hard on the osm2pgsql schema. Any idea why this isn't just highway=mountain_pass ?

comment:13 Changed 3 years ago by vladimir.vyskocil@…

Sorry I don't know why it is like this, but taginfo :  http://taginfo.openstreetmap.de/keys/?key=mountain_pass#values show that it's almost only tagged in this way.

I can't imagine that a such important map feature won't be rendered in the near feature. It is a very valuable information for driving usage of the map but also for hiking.

comment:14 Changed 3 years ago by Ldp

I wasn't disputing the validity of showing mountain passes. Just indicating that currently we have no way to render them, since this tag hierarchy isn't imported into the rendering db yet. We could add it immediately if it was in one of the hierarchies (like highway) that was already in our db. Alas, this isn't the case.

So, we'll only be able to show mountain passes after the next full db import. The last one was about a year ago. A new one should happen soon.

comment:15 Changed 3 years ago by datendelphin

  • Cc datendelphin added
  • Priority changed from minor to major

The mountain_pass is still not rendered as far as I can see. As I have posted on the corresponding nominatim ticket #3655, it is quite limiting that it is neither displayed, nor found. It is an important feature in the alpine region. Please add it or someone tell us what to do to get it on the map.

Converting mountain_pass=yes to highway=mountain_pass seems a bit ridiculous to do just for one renderer. But it is a possibility I think.

comment:16 Changed 6 months ago by ligfietser

mountain_pass=yes is after 4 years still not rendered

comment:17 Changed 6 months ago by AnderOSM

I would also like to insist on the idea that all maps I have ever used include the mountain passes. They are not only important for hiking - they are important references for geographic regions, road traffic...

comment:18 Changed 5 months ago by pnorman

  • Status changed from new to closed
  • Resolution set to wontfix

The "mapnik" component in trac is for the old XML-based openstreetmap.xml stylesheets which are not deployed on OpenStreetMap.org. Since June the default style on OpenStreetMap.org has been openstreetmap-carto, which has its own issue tracker at  https://github.com/gravitystorm/openstreetmap-carto/issues.

I'm going to go ahead and close this issue as wontfix to avoid people being confused by it and commenting on it instead of somewhere where it will effect the rendering on osm.org. Closing it doesn't mean the issue won't be fixed in openstreetmap-carto, just that this ticket is against old unmaintained software that has been replaced and this ticket has zero chance of being resolved.

There is an openstreetmap-carto ticket requesting mountain passes be rendered  https://github.com/gravitystorm/openstreetmap-carto/pull/244, but please read the roadmap at  https://github.com/gravitystorm/openstreetmap-carto#roadmap to understand what issues are an immediate priority.

Note: See TracTickets for help on using tickets.