Opened 10 years ago

Closed 10 years ago

#2242 closed defect (fixed)

Wrong API documentation for gpx uploads?

Reported by: xeen Owned by: Tom Hughes
Priority: critical Milestone:
Component: api Version:
Keywords: Cc:

Description

It seems the API has changed for GPX uploads. I found that all GPX uploads became public even though "public=0" was specified correctly when uploading. I've had a look at the normal GPX upload (http://www.openstreetmap.org/traces/mine) and it seems the API has changed and now uses "visiblity" instead of "public". I modified the DirectUpload? plugin for JOSM and it seems to work again.

I've updated the documention for the 0.6 API to reflect this, but I'd be happy if an API hacker could confirm this and possibly correct my assumptions:

http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6#Uploading_Traces

Maybe the API should return an error if the "public" field is still used or at least default all traces without specified visibility to "private" in order to protect the user's privacy (or match public=0|1 to the most fitting visibility)

Change History (3)

comment:1 Changed 10 years ago by Tom Hughes

Priority: majorcritical
Status: newassigned

Please don't change the documentation when you find a bug - report it and we'll fix it! Especially when it something as serious as this...

comment:2 Changed 10 years ago by Tom Hughes

Actually I see what you mean, so it is correct to update the documentation though we should still respect the old public attribute if visibility is not specified.

comment:3 Changed 10 years ago by tomhughes

Resolution: fixed
Status: assignedclosed

(In [17413]) Fix backwards compatibility code to handle an old style public attribute correctly. Closes #2242.

Note: See TracTickets for help on using tickets.