Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Wrong API documentation for gpx uploads? #2242

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments
Closed

Wrong API documentation for gpx uploads? #2242

openstreetmap-trac opened this issue Jul 23, 2021 · 3 comments

Comments

@openstreetmap-trac
Copy link

Reporter: xeen
[Submitted to the original trac issue database at 6.24pm, Sunday, 30th August 2009]

It seems the API has changed for GPX uploads. I found that all GPX uploads became public even though "public=0" was specified correctly when uploading. I've had a look at the normal GPX upload (http://www.openstreetmap.org/traces/mine) and it seems the API has changed and now uses "visiblity" instead of "public". I modified the DirectUpload plugin for JOSM and it seems to work again.

I've updated the documention for the 0.6 API to reflect this, but I'd be happy if an API hacker could confirm this and possibly correct my assumptions:

http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6#Uploading_Traces

Maybe the API should return an error if the "public" field is still used or at least default all traces without specified visibility to "private" in order to protect the user's privacy (or match public=0|1 to the most fitting visibility)

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 2.48pm, Monday, 31st August 2009]

Please don't change the documentation when you find a bug - report it and we'll fix it! Especially when it something as serious as this...

@openstreetmap-trac
Copy link
Author

Author: tom[at]compton.nu
[Added to the original trac issue at 2.49pm, Monday, 31st August 2009]

Actually I see what you mean, so it is correct to update the documentation though we should still respect the old public attribute if visibility is not specified.

@openstreetmap-trac
Copy link
Author

Author: tomhughes
[Added to the original trac issue at 11.28pm, Monday, 31st August 2009]

(In [17413]) Fix backwards compatibility code to handle an old style public
attribute correctly. Closes #2242.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant