Opened 10 years ago

Closed 6 years ago

#2256 closed enhancement (wontfix)

Undo should preserve node IDs in offline mode

Reported by: Wynndale Owned by: richard@…
Priority: minor Milestone:
Component: potlatch (flash editor) Version:
Keywords: Cc:

Description

When you select a new way and then combine it with an existing one Potlatch gives it a new ID losing the history. Potlatch does the same thing when split is undone.

Change History (4)

comment:1 Changed 10 years ago by Richard

Are you sure about the former? That was fixed in a reasonably recent version, I think, and certainly when I try it, it uses the existing ID. Can you provide steps to reproduce?

Are you editing live or with save?

comment:2 Changed 10 years ago by Nick Austin

The first problem was described in TRAC 2108 amd fixed in Potlatch 1.2.

The second problem is still present in Potlatch 1.2a:
a) Select a way with a positive ObjectID
b) Select a node along that way
c) Press X
d) Press Z
The way now has a negative ObjectID and no history.

comment:3 Changed 10 years ago by Richard

Summary: Potlatch creates new ways unnecessarily disrupting historyUndo should preserve node IDs in offline mode
Type: defectenhancement

Sure.

The problem with the latter is that the server won't let you (AIUI) overwrite a deleted node. Once a node with id n has been deleted, it stays deleted. Therefore Potlatch needs to assign a new, negative id.

This is an issue with editing live. Theoretically, in edit-with-save mode, you could preserve the id (as long as the data hasn't been saved before undoing). However I'm always a bit loth to introduce variant handling to this part of the code, as invariably there'll be an edge case that'll foul something up in complicated ways.

Changing to an enhancement and retitling accordingly.

comment:4 Changed 6 years ago by iandees

Resolution: wontfix
Status: newclosed

Cleaning aging tickets.

Note: See TracTickets for help on using tickets.