Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Undo should preserve node IDs in offline mode #2256

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Closed

Undo should preserve node IDs in offline mode #2256

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Wynndale
[Submitted to the original trac issue database at 7.02pm, Thursday, 3rd September 2009]

When you select a new way and then combine it with an existing one Potlatch gives it a new ID losing the history. Potlatch does the same thing when split is undone.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 8.18am, Friday, 4th September 2009]

Are you sure about the former? That was fixed in a reasonably recent version, I think, and certainly when I try it, it uses the existing ID. Can you provide steps to reproduce?

Are you editing live or with save?

@openstreetmap-trac
Copy link
Author

Author: Nick Austin
[Added to the original trac issue at 6.47pm, Monday, 7th September 2009]

The first problem was described in TRAC 2108 amd fixed in Potlatch 1.2.

The second problem is still present in Potlatch 1.2a:
[[BR]]
a) Select a way with a positive ObjectID
[[BR]]
b) Select a node along that way
[[BR]]
c) Press X
[[BR]]
d) Press Z
[[BR]]
The way now has a negative ObjectID and no history.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 7.14pm, Monday, 7th September 2009]

Sure.

The problem with the latter is that the server won't let you (AIUI) overwrite a deleted node. Once a node with id n has been deleted, it stays deleted. Therefore Potlatch needs to assign a new, negative id.

This is an issue with editing live. Theoretically, in edit-with-save mode, you could preserve the id (as long as the data hasn't been saved before undoing). However I'm always a bit loth to introduce variant handling to this part of the code, as invariably there'll be an edge case that'll foul something up in complicated ways.

Changing to an enhancement and retitling accordingly.

@openstreetmap-trac
Copy link
Author

Author: iandees
[Added to the original trac issue at 8.05pm, Monday, 9th September 2013]

Cleaning aging tickets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant