Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Creating diary entries with "foo <bar blah" as the content will be saved as "foo" with the rest silently dropped #2509

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Closed

Creating diary entries with "foo <bar blah" as the content will be saved as "foo" with the rest silently dropped #2509

openstreetmap-trac opened this issue Jul 23, 2021 · 2 comments
Assignees
@openstreetmap-trac
Labels
Component: website Priority: minor Resolution: fixed Type: defect

Comments

@openstreetmap-trac
Copy link

Reporter: avarab[at]gmail.com
[Submitted to the original trac issue database at 5.38pm, Thursday, 26th November 2009]

  1. Create a diary entry with "foo <bar blah" as the content
  2. Comment on it with the comment "foo <bar blah"

Both the content & the comment will be trimmed to "foo".

I just lost a diary comment because of this because I wrote the less-than sign in my text ("<5">). The HTML sanitizer shouldn't be so eager.
@openstreetmap-trac openstreetmap-trac self-assigned this Jul 23, 2021
@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 6.55pm, Thursday, 26th November 2009]

Diary entries are sanitised when they are displayed, not when they are entered, so the content in the database will be correct.

The sanitisation routines are part of rails, so there isn't a huge amount we can do about this very easily.

@openstreetmap-trac
Copy link
Author

Author: TomH
[Added to the original trac issue at 5.51pm, Saturday, 17th March 2012]

This should be fixed, as we now use Markdown for new diary entries.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@openstreetmap-trac openstreetmap-trac

Labels
Component: website Priority: minor Resolution: fixed Type: defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@openstreetmap-trac