Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#2575 closed defect (fixed)

too easy to close changeset

Reported by: NE2 Owned by: richard@…
Priority: critical Milestone:
Component: potlatch (flash editor) Version:
Keywords: Cc: Tom Hughes

Description

In Potlatch, it's way too easy to accidentally hit the C key and close the changeset. After doing this, it can take on the order of 10-30 minutes to finish. Could a confirmation dialog be added after hitting C?

Change History (10)

comment:1 Changed 10 years ago by Richard

Cc: Tom Hughes added

This isn't really a bug in Potlatch per se. Rather, there appears to be some issue with the server which is causing it to be very slow at closing changesets - none of the relevant code in Potlatch has changed. I haven't figured out why yet.

comment:2 in reply to:  1 Changed 10 years ago by NE2

It's not necessarily a bug, but something that should probably be changed in Potlatch too, since (I believe) one can't undo closing a changeset.

comment:3 Changed 10 years ago by NE2

Did it again (was typing +access and the plus didn't register) and again I'm stuck either waiting and hoping it's not hung or closing and losing my work.

comment:4 Changed 10 years ago by NE2

It seems to have hung. Here's the changeset: http://www.openstreetmap.org/browse/changeset/3569373 It's already closed, and doesn't have the changes I made between the previous save and the accidental close.

comment:5 Changed 10 years ago by Richard

Still haven't managed to pin this one down. It works fine on my local rails_port install.

comment:6 Changed 10 years ago by NE2

Happened again. Please remove the shortcut or something until the bigger problem is fixed.

comment:7 Changed 9 years ago by NE2

Priority: majorcritical

Lost my work again. Why has this not been fixed?

comment:8 Changed 9 years ago by Richard

Probably because you forgot to attach the patch to your trac ticket. You have written one, haven't you?

comment:9 Changed 9 years ago by Richard

Resolution: fixed
Status: newclosed

Fixed hanging in r19849.

comment:10 Changed 9 years ago by NE2

Thanks a lot for fixing :)

Note: See TracTickets for help on using tickets.