Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

too easy to close changeset #2575

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 10 comments
Closed

too easy to close changeset #2575

openstreetmap-trac opened this issue Jul 23, 2021 · 10 comments

Comments

@openstreetmap-trac
Copy link

Reporter: NE2
[Submitted to the original trac issue database at 1.24am, Thursday, 24th December 2009]

In Potlatch, it's way too easy to accidentally hit the C key and close the changeset. After doing this, it can take on the order of 10-30 minutes to finish. Could a confirmation dialog be added after hitting C?

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 7.29am, Thursday, 24th December 2009]

This isn't really a bug in Potlatch per se. Rather, there appears to be some issue with the server which is causing it to be very slow at closing changesets - none of the relevant code in Potlatch has changed. I haven't figured out why yet.

@openstreetmap-trac
Copy link
Author

Author: NE2
[Added to the original trac issue at 8.59pm, Monday, 28th December 2009]

It's not necessarily a bug, but something that should probably be changed in Potlatch too, since (I believe) one can't undo closing a changeset.

@openstreetmap-trac
Copy link
Author

Author: NE2
[Added to the original trac issue at 11.55am, Friday, 8th January 2010]

Did it again (was typing +access and the plus didn't register) and again I'm stuck either waiting and hoping it's not hung or closing and losing my work.

@openstreetmap-trac
Copy link
Author

Author: NE2
[Added to the original trac issue at 12.09pm, Friday, 8th January 2010]

It seems to have hung. Here's the changeset: http://www.openstreetmap.org/browse/changeset/3569373
It's already closed, and doesn't have the changes I made between the previous save and the accidental close.

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 8.44am, Monday, 11th January 2010]

Still haven't managed to pin this one down. It works fine on my local rails_port install.

@openstreetmap-trac
Copy link
Author

Author: NE2
[Added to the original trac issue at 9.42pm, Saturday, 16th January 2010]

Happened again. Please remove the shortcut or something until the bigger problem is fixed.

@openstreetmap-trac
Copy link
Author

Author: NE2
[Added to the original trac issue at 3.28pm, Wednesday, 3rd February 2010]

Lost my work again. Why has this not been fixed?

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 3.29pm, Wednesday, 3rd February 2010]

Probably because you forgot to attach the patch to your trac ticket. You have written one, haven't you?

@openstreetmap-trac
Copy link
Author

Author: Richard
[Added to the original trac issue at 5.04pm, Wednesday, 3rd February 2010]

Fixed hanging in r19849.

@openstreetmap-trac
Copy link
Author

Author: NE2
[Added to the original trac issue at 5.35pm, Wednesday, 3rd February 2010]

Thanks a lot for fixing :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant